Rotation into Video Layer + Content Transform

cc/layers/video_layer.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/video_layer.h"
 
 #include "cc/layers/video_layer_impl.h"
 
 namespace cc {
 
 scoped_refptr<VideoLayer> VideoLayer::Create(VideoFrameProvider* provider) {
   return make_scoped_refptr(new VideoLayer(provider));
 }
 
 VideoLayer::VideoLayer(VideoFrameProvider* provider) : provider_(provider) {
   DCHECK(provider_);
 }
 
 VideoLayer::~VideoLayer() {}
 
 scoped_ptr<LayerImpl> VideoLayer::CreateLayerImpl(LayerTreeImpl* tree_impl) {
-  return VideoLayerImpl::Create(tree_impl, id(), provider_).PassAs<LayerImpl>();
+  scoped_ptr<VideoLayerImpl> impl =
+      VideoLayerImpl::Create(tree_impl, id(), provider_);
+  impl->set_video_rotation(video_rotation_);

[enne (OOO), 2014/07/21 23:42:49]

This should be set during PushProperties.

[suderman, 2014/07/22 00:05:20]

I am willing to make this change however it has moved in and out of push
properties previously (I was asked to add it to push properties then remove it)
so once everything else is sorted out, if we decide to move it to push
properties, I will make that change.

[enne (OOO), 2014/07/22 21:10:39]

Yeah, I disagree with what Dana said.  video_rotation either needs to be an
immutable constructor parameter or a mutable property that is pushed during push
properties.  Right now this code makes it look like a mutable property that's
set in the wrong place.

Can a video change source, reuse the same layer, and have a different rotation?

[suderman, 2014/07/22 21:48:16]

If the video source changes it's metadata will still be processed by the
webmediaplayer making the rotation data set. However even though it doesn't
change moving video_rotation to push_properties groups similar data.

+  return impl.PassAs<LayerImpl>();
 }
 
 bool VideoLayer::Update(ResourceUpdateQueue* queue,
                         const OcclusionTracker<Layer>* occlusion) {
   bool updated = Layer::Update(queue, occlusion);
 
   // Video layer doesn't update any resources from the main thread side,
   // but repaint rects need to be sent to the VideoLayerImpl via commit.
   //
   // This is the inefficient legacy redraw path for videos.  It's better to
   // communicate this directly to the VideoLayerImpl.
   updated |= !update_rect_.IsEmpty();
 
   return updated;
 }
 
 }  // namespace cc