|
Revert 282408 "Use upstream libaddressinput in Chrome."
Introduced static initializers into chrome binary:
preload_supplier.cc _GLOBAL__sub_I_preload_supplier.cc+0xa
preload_supplier.cc i18n::addressinput::StringCompare::StringCompare()
preload_supplier.cc __cxa_atexit@plt [registers a dtor to run at exit]
Run ./tools/linux/dump-static-initializers.py before re-landing to
verify they're no longer present.
> Use upstream libaddressinput in Chrome.
>
> Most of the changes are mechanical switches from chromium/ to src/
> directory in third_party/libadressinput/.
>
> To simplify the switch, autofill::AddressValidator is a shim between
> Chromium and i18n::addressinput::AddressValidator. The shim behaves the
> same way as Chromium's version of libaddressinput. The goal is to
> gradually remove the shim and make Chromium work directly with
> libaddressinupt.
>
> Upstream libaddressinput does not include suggestions, which now can be
> found in third_party/libadressinput/chromium/input_suggester.{h,cc}.
>
> A follow up patch will remove Chromium's version of libaddressinput.
>
> BUG= 327046
>
> Review URL: https://codereview.chromium.org/298863012
TBR=rouslan@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282426
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+567 lines, -3213 lines) |
Patch |
|
M |
trunk/src/build/ios/grit_whitelist.txt
|
View
|
|
1 chunk |
+0 lines, -34 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/autofill/DEPS
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
|
View
|
|
6 chunks |
+6 lines, -11 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
|
View
|
|
9 chunks |
+31 lines, -34 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
|
View
|
|
5 chunks |
+17 lines, -12 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/autofill/autofill_dialog_i18n_input.h
|
View
|
|
1 chunk |
+7 lines, -1 line |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc
|
View
|
|
5 chunks |
+12 lines, -20 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/autofill/country_combobox_model.cc
|
View
|
|
3 chunks |
+5 lines, -18 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/autofill/country_combobox_model_unittest.cc
|
View
|
|
3 chunks |
+3 lines, -6 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/autofill/data_model_wrapper.cc
|
View
|
|
3 chunks |
+8 lines, -10 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/autofill/mock_address_validator.h
|
View
|
|
3 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/webui/DEPS
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
trunk/src/chrome/browser/ui/webui/options/autofill_options_handler.cc
|
View
|
|
4 chunks |
+8 lines, -19 lines |
0 comments
|
Download
|
|
M |
trunk/src/chrome/tools/build/repack_locales.py
|
View
|
|
1 chunk |
+6 lines, -1 line |
0 comments
|
Download
|
|
M |
trunk/src/components/autofill/core/browser/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
trunk/src/components/autofill/core/browser/address_i18n.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
trunk/src/components/autofill/core/browser/autofill_country.cc
|
View
|
|
4 chunks |
+5 lines, -11 lines |
0 comments
|
Download
|
|
M |
trunk/src/components/autofill/core/browser/autofill_country_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -16 lines |
0 comments
|
Download
|
|
M |
trunk/src/components/autofill/core/browser/autofill_profile.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/BUILD.gn
|
View
|
|
3 chunks |
+96 lines, -67 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/README.chromium
|
View
|
|
1 chunk |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/chromium/addressinput_util.h
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/chromium/addressinput_util.cc
|
View
|
|
3 chunks |
+18 lines, -16 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/chromium/addressinput_util_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/chrome_address_validator.h
|
View
|
|
1 chunk |
+0 lines, -186 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/chrome_address_validator.cc
|
View
|
|
1 chunk |
+0 lines, -154 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -740 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/chromium/chrome_downloader_impl.h
|
View
|
|
3 chunks |
+4 lines, -7 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/chromium/chrome_downloader_impl.cc
|
View
|
|
3 chunks |
+24 lines, -28 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/chromium/chrome_downloader_impl_unittest.cc
|
View
|
|
3 chunks |
+12 lines, -16 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/chromium/chrome_rule_test.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/chromium/chrome_storage_impl.h
|
View
|
|
3 chunks |
+8 lines, -6 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/chromium/chrome_storage_impl.cc
|
View
|
|
2 chunks |
+22 lines, -22 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/chromium/chrome_storage_impl_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/fallback_data_store.h
|
View
|
|
1 chunk |
+0 lines, -22 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/fallback_data_store.cc
|
View
|
|
1 chunk |
+0 lines, -203 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/fallback_data_store_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -39 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/input_suggester.h
|
View
|
|
1 chunk |
+0 lines, -133 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/input_suggester.cc
|
View
|
|
1 chunk |
+0 lines, -521 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/chromium/json.cc
|
View
|
|
2 chunks |
+73 lines, -104 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/libaddressinput_util.h
|
View
|
|
1 chunk |
+0 lines, -42 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/libaddressinput_util.cc
|
View
|
|
1 chunk |
+0 lines, -72 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/libaddressinput_util_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -41 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/override/basictypes_override.h
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
|
A + |
trunk/src/third_party/libaddressinput/chromium/preload_address_validator.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
|
A + |
trunk/src/third_party/libaddressinput/chromium/preload_address_validator.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
|
A + |
trunk/src/third_party/libaddressinput/chromium/preload_address_validator_unittest.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/storage_test_runner.h
|
View
|
|
1 chunk |
+0 lines, -47 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/storage_test_runner.cc
|
View
|
|
1 chunk |
+0 lines, -88 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/string_compare.cc
|
View
|
|
1 chunk |
+0 lines, -69 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/string_compare_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -26 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/trie.h
|
View
|
|
1 chunk |
+0 lines, -54 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/trie.cc
|
View
|
|
1 chunk |
+0 lines, -81 lines |
0 comments
|
Download
|
|
D |
trunk/src/third_party/libaddressinput/chromium/trie_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -109 lines |
0 comments
|
Download
|
|
M |
trunk/src/third_party/libaddressinput/libaddressinput.gyp
|
View
|
|
1 chunk |
+172 lines, -93 lines |
0 comments
|
Download
|
|
M |
trunk/src/tools/gritsettings/resource_ids
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|