| Index: trunk/src/third_party/libaddressinput/chromium/chrome_storage_impl.cc
|
| ===================================================================
|
| --- trunk/src/third_party/libaddressinput/chromium/chrome_storage_impl.cc (revision 282425)
|
| +++ trunk/src/third_party/libaddressinput/chromium/chrome_storage_impl.cc (working copy)
|
| @@ -4,10 +4,8 @@
|
|
|
| #include "third_party/libaddressinput/chromium/chrome_storage_impl.h"
|
|
|
| -#include "base/memory/scoped_ptr.h"
|
| #include "base/prefs/writeable_pref_store.h"
|
| #include "base/values.h"
|
| -#include "third_party/libaddressinput/chromium/fallback_data_store.h"
|
|
|
| namespace autofill {
|
|
|
| @@ -19,53 +17,55 @@
|
|
|
| ChromeStorageImpl::~ChromeStorageImpl() {}
|
|
|
| -void ChromeStorageImpl::Put(const std::string& key, std::string* data) {
|
| - DCHECK(data);
|
| - scoped_ptr<std::string> owned_data(data);
|
| +void ChromeStorageImpl::Put(const std::string& key,
|
| + scoped_ptr<std::string> data) {
|
| scoped_ptr<base::StringValue> string_value(
|
| new base::StringValue(std::string()));
|
| - string_value->GetString()->swap(*owned_data);
|
| + string_value->GetString()->swap(*data);
|
| backing_store_->SetValue(key, string_value.release());
|
| }
|
|
|
| -void ChromeStorageImpl::Get(const std::string& key,
|
| - const Storage::Callback& data_ready) const {
|
| +void ChromeStorageImpl::Get(
|
| + const std::string& key,
|
| + scoped_ptr<Storage::Callback> data_ready) const {
|
| // |Get()| should not be const, so this is just a thunk that fixes that.
|
| - const_cast<ChromeStorageImpl*>(this)->DoGet(key, data_ready);
|
| + const_cast<ChromeStorageImpl*>(this)->DoGet(key, data_ready.Pass());
|
| }
|
|
|
| void ChromeStorageImpl::OnPrefValueChanged(const std::string& key) {}
|
|
|
| void ChromeStorageImpl::OnInitializationCompleted(bool succeeded) {
|
| - for (std::vector<Request*>::iterator iter = outstanding_requests_.begin();
|
| + for (std::vector<Request*>::iterator iter =
|
| + outstanding_requests_.begin();
|
| iter != outstanding_requests_.end(); ++iter) {
|
| - DoGet((*iter)->key, (*iter)->callback);
|
| + DoGet((*iter)->key, (*iter)->callback.Pass());
|
| }
|
|
|
| outstanding_requests_.clear();
|
| }
|
|
|
| -void ChromeStorageImpl::DoGet(const std::string& key,
|
| - const Storage::Callback& data_ready) {
|
| +void ChromeStorageImpl::DoGet(
|
| + const std::string& key,
|
| + scoped_ptr<Storage::Callback> data_ready) {
|
| if (!backing_store_->IsInitializationComplete()) {
|
| - outstanding_requests_.push_back(new Request(key, data_ready));
|
| + outstanding_requests_.push_back(
|
| + new Request(key, data_ready.Pass()));
|
| return;
|
| }
|
|
|
| const base::Value* value = NULL;
|
| - scoped_ptr<std::string> data(new std::string);
|
| - if (backing_store_->GetValue(key, &value) && value->GetAsString(data.get())) {
|
| - data_ready(true, key, data.release());
|
| - } else if (FallbackDataStore::Get(key, data.get())) {
|
| - data_ready(true, key, data.release());
|
| + const base::StringValue* string_value = NULL;
|
| + if (backing_store_->GetValue(key, &value) &&
|
| + value->GetAsString(&string_value)) {
|
| + (*data_ready)(true, key, string_value->GetString());
|
| } else {
|
| - data_ready(false, key, NULL);
|
| + (*data_ready)(false, key, std::string());
|
| }
|
| }
|
|
|
| ChromeStorageImpl::Request::Request(const std::string& key,
|
| - const Callback& callback)
|
| + scoped_ptr<Storage::Callback> callback)
|
| : key(key),
|
| - callback(callback) {}
|
| + callback(callback.Pass()) {}
|
|
|
| } // namespace autofill
|
|
|