Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 388573005: Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1 (Closed)

Created:
6 years, 5 months ago by Derek Schuff
Modified:
6 years, 5 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1 This is required to make the PSO generation test pass on ARM hardware; (or more specifically, opt will run on the x86 bot, and get stubbed out on the hardware bot). Stubbing out pnacl-finalize isn't required for that particular test but is just for completeness. R=mseaborn@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3873 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M site_scons/site_tools/naclsdk.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Derek Schuff
6 years, 5 months ago (2014-07-10 19:49:26 UTC) #1
Mark Seaborn
LGTM This is required to roll the PNaCl toolchain rev, right? Before the roll, the ...
6 years, 5 months ago (2014-07-10 20:27:59 UTC) #2
Derek Schuff
On 2014/07/10 20:27:59, Mark Seaborn wrote: > LGTM > > This is required to roll ...
6 years, 5 months ago (2014-07-10 20:28:17 UTC) #3
Derek Schuff
6 years, 5 months ago (2014-07-10 20:42:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r13469 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698