Issue 388573002: Delete dead code (the first if branch) in Benchmark.CreateExpectations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 388573002: Delete dead code (the first if branch) in Benchmark.CreateExpectations. (Closed)

Created:
6 years, 5 months ago by chrishenry

Modified:
6 years, 5 months ago

Reviewers:
nednguyen, dtu

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Delete dead code (the first if branch) in Benchmark.CreateExpectations. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282810

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	tools/telemetry/telemetry/benchmark.py	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

nednguyen

lgtm The class attribute expectation of benchmark class seems to be a syntactic sugar feature ...

6 years, 5 months ago (2014-07-10 18:52:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/388573002/1

6 years, 5 months ago (2014-07-11 21:27:51 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-12 04:41:53 UTC) #5

Message was sent while issue was closed.

Change committed as 282810