tools/telemetry/telemetry/benchmark.py - Issue 388573002: Delete dead code (the first if branch) in Benchmark.CreateExpectations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/benchmark.py

Issue 388573002: Delete dead code (the first if branch) in Benchmark.CreateExpectations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/benchmark.py

diff --git a/tools/telemetry/telemetry/benchmark.py b/tools/telemetry/telemetry/benchmark.py

index 5f3c75d596a1489adc90bde12cdf6870ebaca218..226e2610bba066d4d1f2678b1914eca8088b371f 100644

--- a/tools/telemetry/telemetry/benchmark.py

+++ b/tools/telemetry/telemetry/benchmark.py

@@ -191,10 +191,7 @@ class Benchmark(command_line.Command):

By default, it will create an empty expectations set. Override to generate

custom expectations.

"""

- if hasattr(cls, 'expectations'):

- return cls.expectations

- else:

- return test_expectations.TestExpectations()

+ return test_expectations.TestExpectations()

def AddCommandLineArgs(parser):

« no previous file with comments | « no previous file | no next file » | no next file with comments »