Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: mojo/public/c/system/BUILD.gn

Issue 388333003: Add GN build targets for the rest of mojo/public (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add //mojo/bindings/java to mojo group on android builds Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/c/system/BUILD.gn
diff --git a/mojo/public/c/system/BUILD.gn b/mojo/public/c/system/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..efd348b4152c2e1ad094dbf45c294ee48a80ad55
--- /dev/null
+++ b/mojo/public/c/system/BUILD.gn
@@ -0,0 +1,28 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+source_set("system") {
+ sources = [
+ "buffer.h",
+ "core.h",
+ "data_pipe.h",
+ "functions.h",
+ "macros.h",
+ "message_pipe.h",
+ "system_export.h",
+ "types.h",
+ "../../platform/native/system_thunks.cc",
yzshen1 2014/07/15 20:59:59 nit: Usually, paths started with ../ go to the top
Chris Masone 2014/07/15 21:11:07 Done.
+ "../../platform/native/system_thunks.h",
+ ]
+ defines = [ "MOJO_SYSTEM_IMPLEMENTATION" ]
+
+ # The GYP target analogous to this one builds this code into a
+ # static library. When building for Android, BUILDCONFIG.gn adds
yzshen1 2014/07/15 21:00:00 nit: GYP doesn't use BUILDCONFIG.gn.
Chris Masone 2014/07/15 21:11:07 reworded for clarity
+ # --exclude-libs=ALL globally, which means that all symbols in
+ # static libraries are excluded from export. That's a problem, as
+ # code outside this target needs to be able to call
+ # MojoSetSystemThunks(). Therefore, the GYP target needs to specifiy
+ # that all dependent targets remove that link flag. Since GN uses a
+ # source_set here, this flag change is not needed.
+}

Powered by Google App Engine
This is Rietveld 408576698