Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 # Copyright 2014 The Chromium Authors. All rights reserved. | |
| 2 # Use of this source code is governed by a BSD-style license that can be | |
| 3 # found in the LICENSE file. | |
| 4 | |
| 5 source_set("system") { | |
| 6 sources = [ | |
| 7 "buffer.h", | |
| 8 "core.h", | |
| 9 "data_pipe.h", | |
| 10 "functions.h", | |
| 11 "macros.h", | |
| 12 "message_pipe.h", | |
| 13 "system_export.h", | |
| 14 "types.h", | |
| 15 "../../platform/native/system_thunks.cc", | |
|
yzshen1
2014/07/15 20:59:59
nit: Usually, paths started with ../ go to the top
Chris Masone
2014/07/15 21:11:07
Done.
| |
| 16 "../../platform/native/system_thunks.h", | |
| 17 ] | |
| 18 defines = [ "MOJO_SYSTEM_IMPLEMENTATION" ] | |
| 19 | |
| 20 # The GYP target analogous to this one builds this code into a | |
| 21 # static library. When building for Android, BUILDCONFIG.gn adds | |
|
yzshen1
2014/07/15 21:00:00
nit: GYP doesn't use BUILDCONFIG.gn.
Chris Masone
2014/07/15 21:11:07
reworded for clarity
| |
| 22 # --exclude-libs=ALL globally, which means that all symbols in | |
| 23 # static libraries are excluded from export. That's a problem, as | |
| 24 # code outside this target needs to be able to call | |
| 25 # MojoSetSystemThunks(). Therefore, the GYP target needs to specifiy | |
| 26 # that all dependent targets remove that link flag. Since GN uses a | |
| 27 # source_set here, this flag change is not needed. | |
| 28 } | |
| OLD | NEW |