components/sync_driver/failed_data_types_handler.cc - Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/failed_data_types_handler.cc

Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing unit test, added extra test case, addressed CR feedback. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/sync_driver/failed_data_types_handler.cc

diff --git a/components/sync_driver/failed_data_types_handler.cc b/components/sync_driver/failed_data_types_handler.cc

index 790684447ab79cdbfbe036b086f637696d5ef156..058482dd317c17b98fe5ca481dd994e22b0aa8d6 100644

--- a/components/sync_driver/failed_data_types_handler.cc

+++ b/components/sync_driver/failed_data_types_handler.cc

@@ -45,6 +45,7 @@ bool FailedDataTypesHandler::UpdateFailedDataTypes(const TypeErrorMap& errors) {

unrecoverable_errors_.insert(*iter);

break;

case syncer::SyncError::DATATYPE_ERROR:

+ case syncer::SyncError::DATATYPE_POLICY_ERROR:

data_type_errors_.insert(*iter);

break;

case syncer::SyncError::CRYPTO_ERROR:

« no previous file with comments | « chrome/browser/themes/theme_syncable_service_unittest.cc ('k') | sync/api/sync_error.h » ('j') | no next file with comments »