chrome/browser/themes/theme_syncable_service_unittest.cc - Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_syncable_service_unittest.cc

Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing unit test, added extra test case, addressed CR feedback. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/themes/theme_syncable_service_unittest.cc

diff --git a/chrome/browser/themes/theme_syncable_service_unittest.cc b/chrome/browser/themes/theme_syncable_service_unittest.cc

index afb63ea6bd839918c4f4bae58b3874a68d0904f6..fe22dea94373b10f10c0523097cde825755f3a23 100644

--- a/chrome/browser/themes/theme_syncable_service_unittest.cc

+++ b/chrome/browser/themes/theme_syncable_service_unittest.cc

@@ -535,9 +535,7 @@ TEST_F(ThemeSyncableServiceTest, StopSync) {

error = theme_sync_service_->ProcessSyncChanges(FROM_HERE, changes);

EXPECT_TRUE(error.IsSet());

EXPECT_EQ(syncer::THEMES, error.model_type());

- EXPECT_EQ("datatype error was encountered: Theme syncable service is not "

- "started.",

- error.message());

+ EXPECT_EQ("Theme syncable service is not started.", error.message());

}

TEST_F(ThemeSyncableServiceTest, RestoreSystemThemeBitWhenChangeToCustomTheme) {

« no previous file with comments | « chrome/browser/sync/profile_sync_service_mock.h ('k') | components/sync_driver/failed_data_types_handler.cc » ('j') | no next file with comments »