chrome/browser/sync/glue/frontend_data_type_controller.cc - Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/frontend_data_type_controller.cc

Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing unit test, added extra test case, addressed CR feedback. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/extension_backed_data_type_controller.cc ('k') | chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/frontend_data_type_controller.cc

diff --git a/chrome/browser/sync/glue/frontend_data_type_controller.cc b/chrome/browser/sync/glue/frontend_data_type_controller.cc

index 268a3be1cdcf2ff839eb87a6188d60ed661ec73a..1ccab99cc8366206468d78aad8aaa9ffb6c5354d 100644

--- a/chrome/browser/sync/glue/frontend_data_type_controller.cc

+++ b/chrome/browser/sync/glue/frontend_data_type_controller.cc

@@ -147,7 +147,9 @@ DataTypeController::State FrontendDataTypeController::state() const {

void FrontendDataTypeController::OnSingleDatatypeUnrecoverableError(

const tracked_objects::Location& from_here, const std::string& message) {

RecordUnrecoverableError(from_here, message);

- sync_service_->DisableDatatype(type(), from_here, message);

+ syncer::SyncError error(

+ from_here, syncer::SyncError::DATATYPE_ERROR, message, type());

+ sync_service_->DisableDatatype(error);

}

FrontendDataTypeController::FrontendDataTypeController()