chrome/browser/sync/glue/extension_backed_data_type_controller.cc - Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/extension_backed_data_type_controller.cc

Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing unit test, added extra test case, addressed CR feedback. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc ('k') | chrome/browser/sync/glue/frontend_data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/extension_backed_data_type_controller.cc

diff --git a/chrome/browser/sync/glue/extension_backed_data_type_controller.cc b/chrome/browser/sync/glue/extension_backed_data_type_controller.cc

index de372bc9e3b8214095d81d1ecfaf6f05bef89493..af8c1c61194c942373a5881b5cd86e9fe3b21d8f 100644

--- a/chrome/browser/sync/glue/extension_backed_data_type_controller.cc

+++ b/chrome/browser/sync/glue/extension_backed_data_type_controller.cc

@@ -83,9 +83,12 @@ void ExtensionBackedDataTypeController::OnExtensionUnloaded(

// unloads (e.g. for permission changes). If that becomes a large enough

// issue, we should consider using the extension unload reason to just

// trigger a reconfiguration without disabling (type will be unready).

- sync_service->DisableDatatype(type(),

- FROM_HERE,

- "Extension unloaded");

+ syncer::SyncError error(

+ FROM_HERE,

+ syncer::SyncError::DATATYPE_ERROR,

+ "Extension unloaded",

+ type());

+ sync_service->DisableDatatype(error);

}