Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 387953006: Revert of Update speedometer to use results.AddValue (Closed)

Created:
6 years, 5 months ago by tonyg
Modified:
6 years, 5 months ago
Reviewers:
nednguyen, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Update speedometer to use results.AddValue (https://codereview.chromium.org/386893004/) Reason for revert: Breaks speedometer. Should be a ListOfScalarValues. Traceback (most recent call last): _RunPage at tools/telemetry/telemetry/page/page_runner.py:534 test.RunPage(page, page_state.tab, results) RunPage at tools/telemetry/telemetry/page/page_test.py:247 self.ValidatePage(page, tab, results) ValidatePage at tools/telemetry/telemetry/page/page_measurement.py:62 self.MeasurePage(page, tab, results) MeasurePage at tools/perf/benchmarks/speedometer.py:36 tab.EvaluateJavaScript('benchmarkClient._timeValues'))) __init__ at tools/telemetry/telemetry/value/scalar.py:19 assert isinstance(value, numbers.Number) AssertionError Locals: important : True name : 'Total' page : <telemetry.page.page.Page object at 0x1d6e590> units : 'ms' value : [13237.9869999991, 13351.2720000012, 14052.7640000023, 14136.3950000013, 13685.9580000001, 14048.2879999999, 14010.3279999989, 13941.6210000018, 14087.0519999998, 13388.6279999983] Original issue's description: > Update speedometer to use results.AddValue > > BUG=391943 > TBR=nduca@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282750 TBR=nduca@chromium.org,nednguyen@google.com NOTREECHECKS=true NOTRY=true BUG=391943 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M tools/perf/benchmarks/speedometer.py View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
Created Revert of Update speedometer to use results.AddValue
6 years, 5 months ago (2014-07-12 02:26:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/387953006/1
6 years, 5 months ago (2014-07-12 02:28:03 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 02:32:02 UTC) #3
Message was sent while issue was closed.
Change committed as 282784

Powered by Google App Engine
This is Rietveld 408576698