DescriptionRevert of Update speedometer to use results.AddValue (https://codereview.chromium.org/386893004/)
Reason for revert:
Breaks speedometer. Should be a ListOfScalarValues.
Traceback (most recent call last):
_RunPage at tools/telemetry/telemetry/page/page_runner.py:534
test.RunPage(page, page_state.tab, results)
RunPage at tools/telemetry/telemetry/page/page_test.py:247
self.ValidatePage(page, tab, results)
ValidatePage at tools/telemetry/telemetry/page/page_measurement.py:62
self.MeasurePage(page, tab, results)
MeasurePage at tools/perf/benchmarks/speedometer.py:36
tab.EvaluateJavaScript('benchmarkClient._timeValues')))
__init__ at tools/telemetry/telemetry/value/scalar.py:19
assert isinstance(value, numbers.Number)
AssertionError
Locals:
important : True
name : 'Total'
page : <telemetry.page.page.Page object at 0x1d6e590>
units : 'ms'
value : [13237.9869999991, 13351.2720000012, 14052.7640000023, 14136.3950000013, 13685.9580000001, 14048.2879999999, 14010.3279999989, 13941.6210000018, 14087.0519999998, 13388.6279999983]
Original issue's description:
> Update speedometer to use results.AddValue
>
> BUG=391943
> TBR=nduca@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282750
TBR=nduca@chromium.org,nednguyen@google.com
NOTREECHECKS=true
NOTRY=true
BUG=391943
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282784
Patch Set 1 #
Created: 6 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|