tools/perf/benchmarks/speedometer.py - Issue 387953006: Revert of Update speedometer to use results.AddValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/speedometer.py

Issue 387953006: Revert of Update speedometer to use results.AddValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/speedometer.py

diff --git a/tools/perf/benchmarks/speedometer.py b/tools/perf/benchmarks/speedometer.py

index dc97a63b6d86346b48017ce0ae5f01f9551ba9ad..5de0c1e0fc4ca82032e695f8a4de6a6c0487bfae 100644

--- a/tools/perf/benchmarks/speedometer.py

+++ b/tools/perf/benchmarks/speedometer.py

@@ -21,7 +21,6 @@

from telemetry import benchmark

from telemetry.page import page_measurement

from telemetry.page import page_set

-from telemetry.value import scalar

class SpeedometerMeasurement(page_measurement.PageMeasurement):

@@ -31,9 +30,8 @@

tab.ExecuteJavaScript('benchmarkClient.iterationCount = 10; startTest();')

tab.WaitForJavaScriptExpression(

'benchmarkClient._finishedTestCount == benchmarkClient.testsCount', 600)

- results.AddValue(scalar.ScalarValue(

- results.current_page, 'Total', 'ms',

- tab.EvaluateJavaScript('benchmarkClient._timeValues')))

+ results.Add(

+ 'Total', 'ms', tab.EvaluateJavaScript('benchmarkClient._timeValues'))

@benchmark.Disabled('android') # Times out

« no previous file with comments | « no previous file | no next file » | no next file with comments »