Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: chrome/browser/history/history_service.h

Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index 216c4517f96cdb7513f5a7d0031fdfe51d6916fb..2e10bbe5f4d6a20d6f143b13199392261e978b93 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -443,8 +443,8 @@ class HistoryService : public CancelableRequestProvider,
// Generic Stuff -------------------------------------------------------------
// Schedules a HistoryDBTask for running on the history backend thread. See
- // HistoryDBTask for details on what this does.
- virtual void ScheduleDBTask(scoped_refptr<history::HistoryDBTask> task,
+ // HistoryDBTask for details on what this does. Takes ownership of |task|.
+ virtual void ScheduleDBTask(history::HistoryDBTask* task,
sky 2014/07/14 20:27:44 Make take a scoped_ptr.
Bernhard Bauer 2014/07/15 10:17:24 Done.
base::CancelableTaskTracker* tracker);
// Adds or removes observers for the VisitDatabase.

Powered by Google App Engine
This is Rietveld 408576698