Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 387543002: RenderTextHarfBuzz: Fix glyph offset calculation (Closed)

Created:
6 years, 5 months ago by ckocagil
Modified:
6 years, 5 months ago
Reviewers:
msw, behdad
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

RenderTextHarfBuzz: Fix glyph offset calculation BUG=391203 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M ui/gfx/render_text_harfbuzz.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ckocagil
6 years, 5 months ago (2014-07-10 14:49:26 UTC) #1
msw
lgtm!
6 years, 5 months ago (2014-07-10 15:58:39 UTC) #2
ckocagil
The CQ bit was checked by ckocagil@chromium.org
6 years, 5 months ago (2014-07-10 15:59:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/387543002/1
6 years, 5 months ago (2014-07-10 16:04:01 UTC) #4
behdad
lgtm
6 years, 5 months ago (2014-07-10 16:58:40 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 20:51:18 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 22:46:58 UTC) #7
Message was sent while issue was closed. 
Change committed as 282442

Powered by Google App Engine
This is Rietveld 408576698