Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 387543002: RenderTextHarfBuzz: Fix glyph offset calculation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_harfbuzz.cc
diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc
index a174aeadbc0966d7af9ca91ef7515ee48f294023..38cb05c6098abcde14e9a952786c3186f14f144d 100644
--- a/ui/gfx/render_text_harfbuzz.cc
+++ b/ui/gfx/render_text_harfbuzz.cc
@@ -267,10 +267,9 @@ hb_font_t* CreateHarfBuzzFont(SkTypeface* skia_face, int text_size) {
}
hb_font_t* harfbuzz_font = hb_font_create(face_cache->first);
- // TODO(ckocagil): Investigate whether disabling hinting here has any effect
- // on text quality.
- int upem = hb_face_get_upem(face_cache->first);
- hb_font_set_scale(harfbuzz_font, upem, upem);
+
+ const int scale = SkScalarToFixed(text_size);
+ hb_font_set_scale(harfbuzz_font, scale, scale);
FontData* hb_font_data = new FontData(&face_cache->second);
hb_font_data->paint_.setTypeface(skia_face);
hb_font_data->paint_.setTextSize(text_size);
@@ -1000,7 +999,7 @@ void RenderTextHarfBuzz::ShapeRun(internal::TextRunHarfBuzz* run) {
SkScalarRoundToInt(SkFixedToScalar(hb_positions[i].x_offset));
const int y_offset =
SkScalarRoundToInt(SkFixedToScalar(hb_positions[i].y_offset));
- run->positions[i].set(run->width + x_offset, y_offset);
+ run->positions[i].set(run->width + x_offset, -y_offset);
run->width +=
SkScalarRoundToInt(SkFixedToScalar(hb_positions[i].x_advance));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698