[Variations] Renaming ChromeVariations to ClientVariations.

[Variations] Renaming ChromeVariations to ClientVariations.

This is a cleanup after https://codereview.chromium.org/366373002/

BUG=None
TEST=Variations*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283061

[Mathieu, 2014-07-14 16:03:58]

Hello, 

Can you have a look?

Thanks

[Alexei Svitkine (slow), 2014-07-14 16:38:01]

https://codereview.chromium.org/387393002/diff/1/components/variations/proto/...
File components/variations/proto/client_experiments.proto (right):

https://codereview.chromium.org/387393002/diff/1/components/variations/proto/...
components/variations/proto/client_experiments.proto:13: message
ClientVariations {
I think the proto name should correspond to the file name.

Rename the file to client_variations.proto?

https://codereview.chromium.org/387393002/diff/1/components/variations/proto/...
components/variations/proto/client_experiments.proto:17: // A list of Client
experiment variation IDs that trigger server side
Nit: Don't capitalize "client", here and above.

https://codereview.chromium.org/387393002/diff/1/components/variations/variat...
File components/variations/variations_http_header_provider_unittest.cc (right):

https://codereview.chromium.org/387393002/diff/1/components/variations/variat...
components/variations/variations_http_header_provider_unittest.cc:36:
metrics::ClientVariations proto;
Can the proto be moved to variations namespace?

[Mathieu, 2014-07-14 19:39:56]

Thanks

https://codereview.chromium.org/387393002/diff/1/components/variations/proto/...
File components/variations/proto/client_experiments.proto (right):

https://codereview.chromium.org/387393002/diff/1/components/variations/proto/...
components/variations/proto/client_experiments.proto:13: message
ClientVariations {
On 2014/07/14 16:38:01, Alexei Svitkine wrote:
> I think the proto name should correspond to the file name.
> 
> Rename the file to client_variations.proto?

Done.

https://codereview.chromium.org/387393002/diff/1/components/variations/proto/...
components/variations/proto/client_experiments.proto:17: // A list of Client
experiment variation IDs that trigger server side
On 2014/07/14 16:38:01, Alexei Svitkine wrote:
> Nit: Don't capitalize "client", here and above.

Done.

https://codereview.chromium.org/387393002/diff/1/components/variations/variat...
File components/variations/variations_http_header_provider_unittest.cc (right):

https://codereview.chromium.org/387393002/diff/1/components/variations/variat...
components/variations/variations_http_header_provider_unittest.cc:36:
metrics::ClientVariations proto;
On 2014/07/14 16:38:01, Alexei Svitkine wrote:
> Can the proto be moved to variations namespace?

Done.

[Alexei Svitkine (slow), 2014-07-14 19:43:21]

LGTM with nits, thanks!

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
File components/variations/variations_http_header_provider.cc (right):

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
components/variations/variations_http_header_provider.cc:214:
variations::ClientVariations proto;
Nit: No need for namespace decl here.

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
File components/variations/variations_http_header_provider.h (right):

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
components/variations/variations_http_header_provider.h:31: // A helper class
for maintaining Client experiments and metrics state
Nit: lowercase

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
File components/variations/variations_http_header_provider_unittest.cc (right):

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
components/variations/variations_http_header_provider_unittest.cc:35: if
(!base::Base64Decode(variations, &serialized_proto)) return false;
Nit: Put return on next line.

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
components/variations/variations_http_header_provider_unittest.cc:36:
variations::ClientVariations proto;
Nit: No need for namespace here.

[Mathieu, 2014-07-14 19:50:17]

Submitting, thanks!

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
File components/variations/variations_http_header_provider.cc (right):

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
components/variations/variations_http_header_provider.cc:214:
variations::ClientVariations proto;
On 2014/07/14 19:43:20, Alexei Svitkine wrote:
> Nit: No need for namespace decl here.

Done.

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
File components/variations/variations_http_header_provider.h (right):

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
components/variations/variations_http_header_provider.h:31: // A helper class
for maintaining Client experiments and metrics state
On 2014/07/14 19:43:20, Alexei Svitkine wrote:
> Nit: lowercase

Done.

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
File components/variations/variations_http_header_provider_unittest.cc (right):

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
components/variations/variations_http_header_provider_unittest.cc:35: if
(!base::Base64Decode(variations, &serialized_proto)) return false;
On 2014/07/14 19:43:20, Alexei Svitkine wrote:
> Nit: Put return on next line.

Done.

https://codereview.chromium.org/387393002/diff/20001/components/variations/va...
components/variations/variations_http_header_provider_unittest.cc:36:
variations::ClientVariations proto;
On 2014/07/14 19:43:21, Alexei Svitkine wrote:
> Nit: No need for namespace here.

Done.

[Mathieu, 2014-07-14 19:50:19]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-07-14 19:51:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/387393002/40001

[commit-bot: I haz the power, 2014-07-14 22:43:03]

Change committed as 283061