components/variations/proto/client_experiments.proto - Issue 387393002: [Variations] Renaming ChromeVariations to ClientVariations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/variations/proto/client_experiments.proto

Issue 387393002: [Variations] Renaming ChromeVariations to ClientVariations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « components/variations/proto/chrome_experiments.proto ('k') | components/variations/variations_http_header_provider.h » ('j') | components/variations/variations_http_header_provider_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // Summary of Chrome variations from experiments.	5 // Summary of Client variations from experiments.

6	6

7 syntax = "proto2";	7 syntax = "proto2";

8	8

9 option optimize_for = LITE_RUNTIME;	9 option optimize_for = LITE_RUNTIME;

10	10

11 package metrics;	11 package metrics;

12	12

13 message ChromeVariations {	13 message ClientVariations {
	Alexei Svitkine (slow) 2014/07/14 16:38:01 I think the proto name should correspond to the fi I think the proto name should correspond to the file name. Rename the file to client_variations.proto? Mathieu 2014/07/14 19:39:55 Done. Show quoted text On 2014/07/14 16:38:01, Alexei Svitkine wrote: > I think the proto name should correspond to the file name. > > Rename the file to client_variations.proto? Done.
14 // A list of Chrome experiment variation IDs that are active.	14 // A list of Client experiment variation IDs that are active.

15 repeated int32 variation_id = 1;	15 repeated int32 variation_id = 1;

16	16

17 // A list of Chrome experiment variation IDs that trigger server side	17 // A list of Client experiment variation IDs that trigger server side
	Alexei Svitkine (slow) 2014/07/14 16:38:01 Nit: Don't capitalize "client", here and above. Nit: Don't capitalize "client", here and above. Mathieu 2014/07/14 19:39:55 Done. Show quoted text On 2014/07/14 16:38:01, Alexei Svitkine wrote: > Nit: Don't capitalize "client", here and above. Done.
18 // behavior.	18 // behavior.

19 repeated int32 trigger_variation_id = 3;	19 repeated int32 trigger_variation_id = 3;

20 }	20 }

OLD	NEW