Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chromeos/network/client_cert_resolver.cc

Issue 387103002: Remove bogus error from client_cert_resolver.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/client_cert_resolver.cc
diff --git a/chromeos/network/client_cert_resolver.cc b/chromeos/network/client_cert_resolver.cc
index d16f033c590e2701e809bb75fef63891705d0fde..20de5f82f020733ac7c3993183b526f875db49d2 100644
--- a/chromeos/network/client_cert_resolver.cc
+++ b/chromeos/network/client_cert_resolver.cc
@@ -334,15 +334,10 @@ void ClientCertResolver::ResolveNetworks(
// In any case, don't check this network again in NetworkListChanged.
resolved_networks_.insert(network->path());
- // If this network is not managed, it cannot have a ClientCertPattern.
stevenjb 2014/07/11 21:13:56 It doesn't look like we really need to check wheth
pneubeck (no reviews) 2014/07/12 09:07:10 Right. This was an efficient test for the presence
- if (network->guid().empty())
+ // If this network is not configured, it cannot have a ClientCertPattern.
+ if (network->profile_path().empty())
continue;
- if (network->profile_path().empty()) {
- LOG(ERROR) << "Network " << network->path()
- << " has a GUID but not profile path";
- continue;
- }
const base::DictionaryValue* policy =
managed_network_config_handler_->FindPolicyByGuidAndProfile(
network->guid(), network->profile_path());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698