Remove bogus error from client_cert_resolver.cc

chromeos/network/client_cert_resolver.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/client_cert_resolver.h"
 
 #include <cert.h>
 #include <certt.h>  // for (SECCertUsageEnum) certUsageAnyCA
 #include <pk11pub.h>
 
@@ skipping 316 matching lines @@
 
   // Filter networks with ClientCertPattern. As ClientCertPatterns can only be
   // set by policy, we check there.
   for (NetworkStateHandler::NetworkStateList::const_iterator it =
            networks.begin(); it != networks.end(); ++it) {
     const NetworkState* network = *it;
 
     // In any case, don't check this network again in NetworkListChanged.
     resolved_networks_.insert(network->path());
 
-    // If this network is not managed, it cannot have a ClientCertPattern.

[stevenjb, 2014/07/11 21:13:56]

It doesn't look like we really need to check whether or not this is managed
here? Clearly this is no longer a valid test for that.

[pneubeck (no reviews), 2014/07/12 09:07:10]

Right. This was an efficient test for the presence of a policy in the past.

-    if (network->guid().empty())
+    // If this network is not configured, it cannot have a ClientCertPattern.
+    if (network->profile_path().empty())
       continue;
 
-    if (network->profile_path().empty()) {
-      LOG(ERROR) << "Network " << network->path()
-                 << " has a GUID but not profile path";
-      continue;
-    }
     const base::DictionaryValue* policy =
         managed_network_config_handler_->FindPolicyByGuidAndProfile(
             network->guid(), network->profile_path());
 
     if (!policy) {
       VLOG(1) << "The policy for network " << network->path() << " with GUID "
               << network->guid() << " is not available yet.";
       // Skip this network for now. Once the policy is loaded, PolicyApplied()
       // will retry.
       continue;
@@ skipping 47 matching lines @@
     DBusThreadManager::Get()->GetShillServiceClient()->
         SetProperties(dbus::ObjectPath(it->service_path),
                         shill_properties,
                         base::Bind(&base::DoNothing),
                         base::Bind(&LogError, it->service_path));
     network_state_handler_->RequestUpdateForNetwork(it->service_path);
   }
 }
 
 }  // namespace chromeos