Issue 387023002: Clean up exit status and globals procecessing in llvm2ice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387023002: Clean up exit status and globals procecessing in llvm2ice. (Closed)

Created:
6 years, 5 months ago by Karl

Modified:
6 years, 5 months ago

Reviewers:
Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Clean up exit status and globals procecessing in llvm2ice. Makes IceTranslator.ExitStatus a boolean (rather than int), and changes code to check flag when done. Fixes bug introduced in https://codereview.chromium.org/387023002. Also cleans up the (Ice) Converter class to handle globals processing, rathe than doing it in llvm2ice.cpp. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3894 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b164d20

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -72 lines)			Patch
M	src/IceConverter.h	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	src/IceConverter.cpp	View		3 chunks	+55 lines, -4 lines	0 comments	Download
M	src/IceTranslator.h	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/IceTranslator.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/PNaClTranslator.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/PNaClTranslator.cpp	View	1 2	7 chunks	+11 lines, -11 lines	0 comments	Download
M	src/llvm2ice.cpp	View	1 2	3 chunks	+3 lines, -48 lines	0 comments	Download

Total messages: 4 (0 generated)

Jim Stichnoth

LGTM, except I would rename ExitStatus to something like ErrorStatus to make the true/false meaning ...

6 years, 5 months ago (2014-07-11 16:45:59 UTC) #2

Karl

Committed patchset #3 manually as rb164d20 (presubmit successful).

6 years, 5 months ago (2014-07-11 17:26:42 UTC) #3

Message was sent while issue was closed.

Changed ExitStatus to ErrorStatus and committed.