ifdef extensions code in BrowserProcess, IOThread, and ChromeNetworkDelegate.

chrome/browser/browser_process_impl.h

Index: chrome/browser/browser_process_impl.h
diff --git a/chrome/browser/browser_process_impl.h b/chrome/browser/browser_process_impl.h
index 7f5de8fdc6077c688ae21e3ca729614a42c6dad4..679bda43dd7bd4a4ccda957716e8ebc977a9fe07 100644
--- a/chrome/browser/browser_process_impl.h
+++ b/chrome/browser/browser_process_impl.h
@@ -195,21 +195,25 @@ class BrowserProcessImpl : public BrowserProcess,
   scoped_ptr<GpuModeManager> gpu_mode_manager_;
 
   scoped_ptr<extensions::ExtensionsBrowserClient> extensions_browser_client_;

[Ryan Sleevi, 2014/07/16 20:23:43]

Why doesn't this have to be #ifdef'd? It's in the extensions namespace.

[Lei Zhang, 2014/07/18 01:34:24]

Too many pieces depend on the ExtensionsBrowserClient to exist. Thus I'm picking
off many of the other pieces in manageable CLs size-wise before going in and
removing the all the browser-side extensions code in one big swoop.

+#if defined(ENABLE_EXTENSIONS)
   scoped_refptr<extensions::EventRouterForwarder>
       extension_event_router_forwarder_;
+#endif
 
 #if !defined(OS_ANDROID)
   scoped_ptr<RemoteDebuggingServer> remote_debugging_server_;
 #endif
 
-#if !defined(OS_ANDROID) && !defined(OS_IOS)
+#if defined(ENABLE_EXTENSIONS)
   scoped_ptr<MediaFileSystemRegistry> media_file_system_registry_;
 #endif
 
+#if defined(ENABLE_FULL_PRINTING)
   scoped_refptr<printing::PrintPreviewDialogController>
       print_preview_dialog_controller_;
 
   scoped_ptr<printing::BackgroundPrintingManager> background_printing_manager_;
+#endif

[Ryan Sleevi, 2014/07/16 20:23:43]

I'm assuming the order of shutdown is particularly pertinent here with respect
to MediaFileSystemRegistry before RemoteDebugging before EventRouterForwarder?

Otherwise, would it make more sense to encapsulate this into a scoped_ptr<> of
some ExtensionsCrap struct (forward declared in the .h), where the .cc has the
ERF, MFSR, and PPDC/BPM objects hanging off?

The benefit here is to reduce the number of publicly-visible (read: in the
header) ifdefs, especially since they affect object size computations.

[Lei Zhang, 2014/07/18 01:34:24]

The printing bits are separate from the extensions bits. I just happened to
notice they are ifdef'd out in the .cc file but not here. That leaves only 3
member variables that are extensions only. I'm kind of meh about making a struct
for so few. I did reorder them so they are all in 1 #ifdef.

 
   // Manager for desktop notification UI.
   bool created_notification_ui_manager_;