ifdef extensions code in BrowserProcess, IOThread, and ChromeNetworkDelegate.

chrome/browser/browser_process_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // When each service is created, we set a flag indicating this. At this point,
 // the service initialization could fail or succeed. This allows us to remember
 // if we tried to create a service, and not try creating it over and over if
 // the creation failed.
 
 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
@@ skipping 176 matching lines @@
   bool created_local_state_;
   scoped_ptr<PrefService> local_state_;
 
   bool created_icon_manager_;
   scoped_ptr<IconManager> icon_manager_;
 
   scoped_ptr<GLStringManager> gl_string_manager_;
 
   scoped_ptr<GpuModeManager> gpu_mode_manager_;
 
   scoped_ptr<extensions::ExtensionsBrowserClient> extensions_browser_client_;

[Ryan Sleevi, 2014/07/16 20:23:43]

Why doesn't this have to be #ifdef'd? It's in the extensions namespace.

[Lei Zhang, 2014/07/18 01:34:24]

Too many pieces depend on the ExtensionsBrowserClient to exist. Thus I'm picking
off many of the other pieces in manageable CLs size-wise before going in and
removing the all the browser-side extensions code in one big swoop.

+#if defined(ENABLE_EXTENSIONS)
   scoped_refptr<extensions::EventRouterForwarder>
       extension_event_router_forwarder_;
+#endif
 
 #if !defined(OS_ANDROID)
   scoped_ptr<RemoteDebuggingServer> remote_debugging_server_;
 #endif
 
-#if !defined(OS_ANDROID) && !defined(OS_IOS)
+#if defined(ENABLE_EXTENSIONS)
   scoped_ptr<MediaFileSystemRegistry> media_file_system_registry_;
 #endif
 
+#if defined(ENABLE_FULL_PRINTING)
   scoped_refptr<printing::PrintPreviewDialogController>
       print_preview_dialog_controller_;
 
   scoped_ptr<printing::BackgroundPrintingManager> background_printing_manager_;
+#endif

[Ryan Sleevi, 2014/07/16 20:23:43]

I'm assuming the order of shutdown is particularly pertinent here with respect
to MediaFileSystemRegistry before RemoteDebugging before EventRouterForwarder?

Otherwise, would it make more sense to encapsulate this into a scoped_ptr<> of
some ExtensionsCrap struct (forward declared in the .h), where the .cc has the
ERF, MFSR, and PPDC/BPM objects hanging off?

The benefit here is to reduce the number of publicly-visible (read: in the
header) ifdefs, especially since they affect object size computations.

[Lei Zhang, 2014/07/18 01:34:24]

The printing bits are separate from the extensions bits. I just happened to
notice they are ifdef'd out in the .cc file but not here. That leaves only 3
member variables that are extensions only. I'm kind of meh about making a struct
for so few. I did reorder them so they are all in 1 #ifdef.

 
   // Manager for desktop notification UI.
   bool created_notification_ui_manager_;
   scoped_ptr<NotificationUIManager> notification_ui_manager_;
 
   scoped_ptr<IntranetRedirectDetector> intranet_redirect_detector_;
 
   scoped_ptr<StatusTray> status_tray_;
 
   scoped_ptr<BackgroundModeManager> background_mode_manager_;
@@ skipping 69 matching lines @@
 #endif
 
   scoped_ptr<network_time::NetworkTimeTracker> network_time_tracker_;
 
   scoped_ptr<gcm::GCMDriver> gcm_driver_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl);
 };
 
 #endif  // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_