Issue 386953002: Make WebGLRenderingContext.getAttachedShaders() return type nullable

Issue 386953002: Make WebGLRenderingContext.getAttachedShaders() return type nullable (Closed)

Created:
6 years, 5 months ago by Jens Widell

Modified:
6 years, 5 months ago

Reviewers:
haraken, Ken Russell (switch to Gerrit)

CC:
blink-reviews, arv+blink, blink-reviews-html_chromium.org, abarth-chromium, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, Inactive, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Make WebGLRenderingContext.getAttachedShaders() return type nullable This allows it to return null when the context is lost or when an error occurs, without resorting to a custom binding for the method. BUG=390780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177935

Patch Set 1 #

Patch Set 2 : fix additional test expectations #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -41 lines)			Patch
M	LayoutTests/fast/canvas/webgl/gl-object-get-calls-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/virtual/gpu/fast/canvas/webgl/gl-object-get-calls-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp	View		1 chunk	+0 lines, -33 lines	0 comments	Download
M	Source/core/html/canvas/WebGLRenderingContextBase.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/canvas/WebGLRenderingContextBase.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/canvas/WebGLRenderingContextBase.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Jens Widell

PTAL Same fix as for getSupportedExtensions(), getting rid of another custom method.

6 years, 5 months ago (2014-07-11 10:17:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/386953002/20001

6 years, 5 months ago (2014-07-11 11:17:56 UTC) #4

Ken Russell (switch to Gerrit)

6 years, 5 months ago (2014-07-12 00:09:37 UTC) #6

Message was sent while issue was closed.

Nice. Sorry for the delayed review; LGTM after the fact.

Expand Messages | Collapse Messages