Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/telemetry/telemetry/results/html_output_formatter_unittest.py

Issue 386943007: Plumb Telemetry test name through to results object creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Got rid of unnecessary fake Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/html_output_formatter_unittest.py
diff --git a/tools/telemetry/telemetry/results/html_output_formatter_unittest.py b/tools/telemetry/telemetry/results/html_output_formatter_unittest.py
index 8b4b0a0cc7e13be73418e6948ccd57551eff77cb..693d6c5f32e6dd853e6b33504769e28bb5f2e680 100644
--- a/tools/telemetry/telemetry/results/html_output_formatter_unittest.py
+++ b/tools/telemetry/telemetry/results/html_output_formatter_unittest.py
@@ -5,6 +5,7 @@ import os
import StringIO
import unittest
+from telemetry import benchmark
from telemetry.page import page_set
from telemetry.results import html_output_formatter
from telemetry.results import page_test_results
@@ -27,6 +28,9 @@ class DeterministicHtmlOutputFormatter(
def _GetRevision(self):
return 'revision'
+class FakeMetadataForTest(benchmark.BenchmarkMetadata):
+ def __init__(self):
+ super(FakeMetadataForTest, self).__init__('test_name')
# Wrap string IO with a .name property so that it behaves more like a file.
class StringIOFile(StringIO.StringIO):
@@ -54,7 +58,7 @@ class HtmlOutputFormatterTest(unittest.TestCase):
results.DidRunPage(test_page_set.pages[1])
formatter = DeterministicHtmlOutputFormatter(
- output_file, 'test_name', False, False, 'browser_type')
+ output_file, FakeMetadataForTest(), False, False, 'browser_type')
formatter.Format(results)
expected = {
"platform": "browser_type",
@@ -111,7 +115,7 @@ class HtmlOutputFormatterTest(unittest.TestCase):
results.DidRunPage(test_page_set.pages[1])
formatter = DeterministicHtmlOutputFormatter(
- output_file, 'test_name', False, False, 'browser_type')
+ output_file, FakeMetadataForTest(), False, False, 'browser_type')
formatter.Format(results)
expected = [
{
@@ -207,7 +211,7 @@ class HtmlOutputFormatterTest(unittest.TestCase):
results.DidRunPage(test_page_set.pages[1])
formatter = DeterministicHtmlOutputFormatter(
- output_file, 'test_name', True, False, 'browser_type')
+ output_file, FakeMetadataForTest(), True, False, 'browser_type')
formatter.Format(results)
expected = [{
"platform": "browser_type",
« no previous file with comments | « tools/telemetry/telemetry/results/html_output_formatter.py ('k') | tools/telemetry/telemetry/results/json_output_formatter.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698