Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: tools/telemetry/telemetry/results/html_output_formatter.py

Issue 386943007: Plumb Telemetry test name through to results object creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Got rid of unnecessary fake Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/html_output_formatter.py
diff --git a/tools/telemetry/telemetry/results/html_output_formatter.py b/tools/telemetry/telemetry/results/html_output_formatter.py
index ec8966fbfe6c105b17935f48e06b181ca9a1b5e8..96ca479b0004dd398e1a3d931eb2e255700a22c1 100644
--- a/tools/telemetry/telemetry/results/html_output_formatter.py
+++ b/tools/telemetry/telemetry/results/html_output_formatter.py
@@ -30,12 +30,12 @@ _UNIT_JSON = ('tools', 'perf', 'unit-info.json')
# Leaving as-is now since we are going to move HtmlOutputFormatter to be
# based on JSON anyway.
class HtmlOutputFormatter(buildbot_output_formatter.BuildbotOutputFormatter):
- def __init__(self, output_stream, test_name, reset_results, upload_results,
+ def __init__(self, output_stream, metadata, reset_results, upload_results,
browser_type, results_label=None, trace_tag=''):
# Pass output_stream=None so that we blow up if
# BuildbotOutputFormatter ever use the output_stream.
super(HtmlOutputFormatter, self).__init__(None, trace_tag)
- self._test_name = test_name
+ self._metadata = metadata
self._reset_results = reset_results
self._upload_results = upload_results
self._html_output_stream = output_stream
@@ -101,6 +101,10 @@ class HtmlOutputFormatter(buildbot_output_formatter.BuildbotOutputFormatter):
'important': result_type == 'default'
}
+ @property
+ def _test_name(self):
+ return self._metadata.name
+
def GetResults(self):
return self._result

Powered by Google App Engine
This is Rietveld 408576698