Issue 386943006: Pull buildtools to get GN r282653

Issue 386943006: Pull buildtools to get GN r282653 (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
awong

CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, tfarina, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Pull buildtools to get GN r282653 This uses the proto file directory for the generated files rather than the directory of the BUILD file. This makes it more natural when you have a BUILD file in a different directory than the proto files. Fixes a search-and-replace error that accidentally changed the fallback source_prereqs code to use "inputs". Fix ozone build. BUG= R=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282998

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : Fix GN proto #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -51 lines)			Patch
M	DEPS	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	build/secondary/tools/grit/grit_rule.gni	View	1 2 3 4	1 chunk	+6 lines, -3 lines	0 comments	Download
M	components/autofill/content/browser/BUILD.gn	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/policy/BUILD.gn	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	device/media_transfer_protocol/BUILD.gn	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	third_party/libphonenumber/BUILD.gn	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -2 lines	0 comments	Download
M	third_party/protobuf/proto_library.gni	View	1 2 3 4 5 6	5 chunks	+26 lines, -34 lines	0 comments	Download
M	tools/gn/file_template.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/gn/filesystem_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/target_generator.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/ozone/BUILD.gn	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

Depends on https://codereview.chromium.org/387663003/ I will add a GN binary roll onto this patch which will ...

6 years, 5 months ago (2014-07-11 16:48:09 UTC) #1

awong

LGTM w/ comment nit. https://codereview.chromium.org/386943006/diff/60001/build/secondary/tools/grit/grit_rule.gni File build/secondary/tools/grit/grit_rule.gni (right): https://codereview.chromium.org/386943006/diff/60001/build/secondary/tools/grit/grit_rule.gni#newcode190 build/secondary/tools/grit/grit_rule.gni:190: # The inputs are relative ...

6 years, 5 months ago (2014-07-11 19:52:20 UTC) #2

Message was sent while issue was closed.

Committed patchset #10 manually as r282998.

Expand Messages | Collapse Messages