tools/gn/filesystem_utils.cc - Issue 386943006: Pull buildtools to get GN r282653

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/filesystem_utils.cc

Issue 386943006: Pull buildtools to get GN r282653 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/filesystem_utils.cc

diff --git a/tools/gn/filesystem_utils.cc b/tools/gn/filesystem_utils.cc

index 17fec9f4fb6187d30d73750883896a80ba5b13e3..097a2276b225003214253be93a479207a360c0c6 100644

--- a/tools/gn/filesystem_utils.cc

+++ b/tools/gn/filesystem_utils.cc

@@ -340,7 +340,7 @@ bool EnsureStringIsInOutputDir(const SourceDir& dir,

// This check will be wrong for all proper prefixes "e.g. "/output" will

// match "/out" but we don't really care since this is just a sanity check.

const std::string& dir_str = dir.value();

- if (str.compare(0, dir_str.length(), dir_str, 0, dir_str.length()) == 0)

+ if (str.compare(0, dir_str.length(), dir_str) == 0)

return true; // Output directory is hardcoded.

if (allow_templates) {

« no previous file with comments | « tools/gn/file_template.h ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »