Fix check in PasswordManager to allow saving credentials from forms only having a new password.

Fix check in PasswordManager to allow saving credentials from forms only having a new password.

BUG=375333
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282705

[engedy, 2014-07-11 19:01:05]

@Vaclav, this is fixing the issue in
PasswordManager::ProvisionallySavePassword() you have discovered. Please take a
look.

[vabr (Chromium), 2014-07-11 19:14:23]

LGTM,
Thanks for fixing this!
Vaclav

https://codereview.chromium.org/386933007/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/386933007/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager_unittest.cc:277:
manager()->OnPasswordFormsRendered(observed,
nit: Put the comment on 1 line, and the code on another one, instead of breaking
the code just to keep the comment at the end.

https://codereview.chromium.org/386933007/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager_unittest.cc:288: //
The value of the new password field should have be promoted to, and saved
nit: s/be/been/

[engedy, 2014-07-11 19:18:54]

https://codereview.chromium.org/386933007/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/386933007/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager_unittest.cc:277:
manager()->OnPasswordFormsRendered(observed,
On 2014/07/11 19:14:23, vabr (Chromium) wrote:
> nit: Put the comment on 1 line, and the code on another one, instead of
breaking
> the code just to keep the comment at the end.

As discussed offline, I have removed the comments from here for now, and will
look at the whole file in a follow-up CL.

https://codereview.chromium.org/386933007/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager_unittest.cc:288: //
The value of the new password field should have be promoted to, and saved
On 2014/07/11 19:14:23, vabr (Chromium) wrote:
> nit: s/be/been/

Done.

[engedy, 2014-07-11 19:18:56]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2014-07-11 19:21:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/engedy@chromium.org/386933007/20001

[commit-bot: I haz the power, 2014-07-11 21:42:46]

Change committed as 282705