components/password_manager/core/browser/password_manager.cc - Issue 386933007: Fix check in PasswordManager to allow saving credentials from forms only having a new password.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 386933007: Fix check in PasswordManager to allow saving credentials from forms only having a new password. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index 85ad67d89ea3e2996a6149177a8c7d4b07707b57..bd0054e893b155f21fad501be7e4a102b98530ea 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -141,7 +141,7 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {

}

// No password to save? Then don't.

- if (form.password_value.empty()) {

+ if (form.password_value.empty() && form.new_password_value.empty()) {

RecordFailure(EMPTY_PASSWORD, form.origin.host(), logger.get());

return;

}

« no previous file with comments | « no previous file | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »