Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: Source/bindings/tests/results/V8TestInterfaceNode.cpp

Issue 386613002: FYI: Compile fixes when always using a local for method return value Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-nullable-method-return-type
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterfaceNode.cpp
diff --git a/Source/bindings/tests/results/V8TestInterfaceNode.cpp b/Source/bindings/tests/results/V8TestInterfaceNode.cpp
index bdfaef4a4bd18284d2d5dc99ca2d6654b63c89dd..0d671360d5a89c392175fdabc777af854ca4a923 100644
--- a/Source/bindings/tests/results/V8TestInterfaceNode.cpp
+++ b/Source/bindings/tests/results/V8TestInterfaceNode.cpp
@@ -210,7 +210,8 @@ static void reflectUrlStringAttributeAttributeSetterCallback(v8::Local<v8::Strin
static void testInterfaceEmptyMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestInterfaceNode* impl = V8TestInterfaceNode::toNative(info.Holder());
- v8SetReturnValueFast(info, WTF::getPtr(impl->testInterfaceEmptyMethod()), impl);
+ RefPtr<TestInterfaceEmpty> result = impl->testInterfaceEmptyMethod();
+ v8SetReturnValueFast(info, WTF::getPtr(result.release()), impl);
}
static void testInterfaceEmptyMethodMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -223,7 +224,8 @@ static void testInterfaceEmptyMethodMethodCallback(const v8::FunctionCallbackInf
static void perWorldBindingsTestInterfaceEmptyMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestInterfaceNode* impl = V8TestInterfaceNode::toNative(info.Holder());
- v8SetReturnValueFast(info, WTF::getPtr(impl->perWorldBindingsTestInterfaceEmptyMethod()), impl);
+ RefPtr<TestInterfaceEmpty> result = impl->perWorldBindingsTestInterfaceEmptyMethod();
+ v8SetReturnValueFast(info, WTF::getPtr(result.release()), impl);
}
static void perWorldBindingsTestInterfaceEmptyMethodMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -236,7 +238,8 @@ static void perWorldBindingsTestInterfaceEmptyMethodMethodCallback(const v8::Fun
static void perWorldBindingsTestInterfaceEmptyMethodMethodForMainWorld(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestInterfaceNode* impl = V8TestInterfaceNode::toNative(info.Holder());
- v8SetReturnValueForMainWorld(info, WTF::getPtr(impl->perWorldBindingsTestInterfaceEmptyMethod()));
+ RefPtr<TestInterfaceEmpty> result = impl->perWorldBindingsTestInterfaceEmptyMethod();
+ v8SetReturnValueForMainWorld(info, WTF::getPtr(result.release()));
}
static void perWorldBindingsTestInterfaceEmptyMethodMethodCallbackForMainWorld(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -254,12 +257,14 @@ static void perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethod(con
v8::TryCatch block;
V8RethrowTryCatchScope rethrow(block);
if (UNLIKELY(info.Length() <= 0)) {
- v8SetReturnValueFast(info, WTF::getPtr(impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg()), impl);
+ RefPtr<TestInterfaceEmpty> result = impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg();
+ v8SetReturnValueFast(info, WTF::getPtr(result.release()), impl);
return;
}
TONATIVE_VOID_INTERNAL(optionalBooleanArgument, info[0]->BooleanValue());
}
- v8SetReturnValueFast(info, WTF::getPtr(impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg(optionalBooleanArgument)), impl);
+ RefPtr<TestInterfaceEmpty> result = impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg(optionalBooleanArgument);
+ v8SetReturnValueFast(info, WTF::getPtr(result.release()), impl);
}
static void perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -277,12 +282,14 @@ static void perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethodForM
v8::TryCatch block;
V8RethrowTryCatchScope rethrow(block);
if (UNLIKELY(info.Length() <= 0)) {
- v8SetReturnValueForMainWorld(info, WTF::getPtr(impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg()));
+ RefPtr<TestInterfaceEmpty> result = impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg();
+ v8SetReturnValueForMainWorld(info, WTF::getPtr(result.release()));
return;
}
TONATIVE_VOID_INTERNAL(optionalBooleanArgument, info[0]->BooleanValue());
}
- v8SetReturnValueForMainWorld(info, WTF::getPtr(impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg(optionalBooleanArgument)));
+ RefPtr<TestInterfaceEmpty> result = impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg(optionalBooleanArgument);
+ v8SetReturnValueForMainWorld(info, WTF::getPtr(result.release()));
}
static void perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethodCallbackForMainWorld(const v8::FunctionCallbackInfo<v8::Value>& info)

Powered by Google App Engine
This is Rietveld 408576698