Source/bindings/tests/results/V8TestInterface2.cpp - Issue 386613002: FYI: Compile fixes when always using a local for method return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterface2.cpp

Issue 386613002: FYI: Compile fixes when always using a local for method return value Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-nullable-method-return-type

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterface.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceNode.cpp » ('j') | Source/bindings/tests/results/V8TestObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterface2.cpp

diff --git a/Source/bindings/tests/results/V8TestInterface2.cpp b/Source/bindings/tests/results/V8TestInterface2.cpp

index c55d5311469ed5ae581d4048e369872fc12c8a63..8a49cd230fa832f8b8965ffb4de71b130a09e690 100644

--- a/Source/bindings/tests/results/V8TestInterface2.cpp

+++ b/Source/bindings/tests/results/V8TestInterface2.cpp

@@ -222,7 +222,8 @@ static void deleteNamedItemMethodCallback(const v8::FunctionCallbackInfo<v8::Val

static void stringifierMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

{

TestInterface2* impl = V8TestInterface2::toNative(info.Holder());

- v8SetReturnValueString(info, impl->stringifierMethod(), info.GetIsolate());

+ String result = impl->stringifierMethod();

+ v8SetReturnValueString(info, result, info.GetIsolate());

}

static void stringifierMethodMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

@@ -235,7 +236,8 @@ static void stringifierMethodMethodCallback(const v8::FunctionCallbackInfo<v8::V

static void toStringMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

{

TestInterface2* impl = V8TestInterface2::toNative(info.Holder());

- v8SetReturnValueString(info, impl->stringifierMethod(), info.GetIsolate());

+ String result = impl->stringifierMethod();

+ v8SetReturnValueString(info, result, info.GetIsolate());

}

static void toStringMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)