Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 386613002: FYI: Compile fixes when always using a local for method return value Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-nullable-method-return-type
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_types.py
diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py
index b3de551a046925d0934b46b7fc82b22bae4b2bcc..ff303fa9e3fc4d88202e6305461db6ac61d4ac44 100644
--- a/Source/bindings/scripts/v8_types.py
+++ b/Source/bindings/scripts/v8_types.py
@@ -667,10 +667,17 @@ def v8_set_return_value_union(idl_type, cpp_value, extended_attributes=None, scr
IdlType.v8_set_return_value = v8_set_return_value
IdlUnionType.v8_set_return_value = v8_set_return_value_union
-IdlType.release = property(lambda self: self.is_interface_type)
-IdlUnionType.release = property(
- lambda self: [member_type.is_interface_type
- for member_type in self.member_types])
+
+def type_needs_release(idl_type):
+ return idl_type.is_interface_type and idl_type.base_type != 'SerializedScriptValue'
+
+
+def union_type_needs_release(idl_type):
+ return [type_needs_release(member_type)
+ for member_type in idl_type.member_types]
+
+IdlType.release = property(type_needs_release)
+IdlUnionType.release = property(union_type_needs_release)
CPP_VALUE_TO_V8_VALUE = {

Powered by Google App Engine
This is Rietveld 408576698