Source/bindings/scripts/v8_methods.py - Issue 386613002: FYI: Compile fixes when always using a local for method return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 386613002: FYI: Compile fixes when always using a local for method return value Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-nullable-method-return-type

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index 92e4fbc6eacefa672eb0d93773fef20730f0681b..086e10aba7524a863e4ed9ac0a4556d40cdd47bf 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -68,13 +68,7 @@ def argument_needs_try_catch(argument):

def use_local_result(method):

- extended_attributes = method.extended_attributes

- idl_type = method.idl_type

- return (has_extended_attribute_value(method, 'CallWith', 'ScriptState') or

- 'ImplementedInPrivateScript' in extended_attributes or

- 'RaisesException' in extended_attributes or

- idl_type.is_union_type or

- (idl_type.is_nullable and not idl_type.is_nullable_simple))

+ return True

def method_context(interface, method):

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_types.py » ('j') | Source/bindings/tests/results/V8TestObject.cpp » ('J')