Remove --disable-fullscreen-within-tab command-line flag.

Remove --disable-fullscreen-within-tab command-line flag.

The new UI code path for fullscreen is stable, and has been out for
several months now.  This change removes the command-line flag, and
also cleans up the UI code in a few places where a boolean switch is no
longer necessary.

BUG=256870
TEST=Confirm Flash fullscreen video still works on Aura and Mac, and with/without tab capture engaged.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283243

[miu, 2014-07-10 04:29:19]

Hi,

Removing a command-line flag we don't need anymore, with a little clean-up. 
PTAL:

avi:
 chrome/browser/ui/cocoa/*

ben:
 Everything else (not cocoa).

[Avi (use Gerrit), 2014-07-10 05:30:04]

LGTM; can you rip more stuff out?

https://codereview.chromium.org/386463002/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/386463002/diff/1/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:1604: bool Browser::EmbedsFullscreenWidget() const
{
Is this a useful function if it always returns true? Can we kill it?

[miu, 2014-07-10 06:20:16]

avi: Unfortunately, I can't rip more stuff out.  This change covers everything
in the browser UI that was switchable and no longer needs to be.  There are
other WebContentsDelegates that do not support embedding the FS widget, so
things like views::WebView and WebContentsImpl need to remain run-time
switchable.

https://codereview.chromium.org/386463002/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/386463002/diff/1/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:1604: bool Browser::EmbedsFullscreenWidget() const
{
On 2014/07/10 05:30:04, Avi (OOO July 11-27) wrote:
> Is this a useful function if it always returns true? Can we kill it?

Can't kill it.  It's an override of
WebContentsDelegate::EmbedsFullscreenWidget(), and there are other delegates
that would return false.

[Avi (use Gerrit), 2014-07-10 13:14:22]

https://codereview.chromium.org/386463002/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/386463002/diff/1/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:1604: bool Browser::EmbedsFullscreenWidget() const
{
No problem.

[Ben Goodger (Google), 2014-07-14 19:24:18]

lgtm

[miu, 2014-07-14 19:56:43]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2014-07-14 19:59:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miu@chromium.org/386463002/20001

[commit-bot: I haz the power, 2014-07-15 10:48:10]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-15 16:50:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-15 16:50:09]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[miu, 2014-07-15 18:10:42]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2014-07-15 18:12:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miu@chromium.org/386463002/20001

[commit-bot: I haz the power, 2014-07-15 19:56:17]

Change committed as 283243