Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4131)

Unified Diff: chrome/browser/ui/fullscreen/fullscreen_controller.h

Issue 386463002: Remove --disable-fullscreen-within-tab command-line flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/fullscreen/fullscreen_controller.h
diff --git a/chrome/browser/ui/fullscreen/fullscreen_controller.h b/chrome/browser/ui/fullscreen/fullscreen_controller.h
index f5f56da6ba1bd96e220d44b27bc46ad4b04c56f5..f9fff193c79d4d7c029b88ac5dedb0032d0c0e4a 100644
--- a/chrome/browser/ui/fullscreen/fullscreen_controller.h
+++ b/chrome/browser/ui/fullscreen/fullscreen_controller.h
@@ -38,18 +38,17 @@ class WebContents;
// this for us.
//
// FullscreenWithinTab Note:
-// When the browser is configured as such, all fullscreen widgets are displayed
-// within the tab contents area, and FullscreenController will expand the
-// browser window so that the tab contents area fills the entire
-// screen. However, special behavior applies when a tab is being
-// screen-captured. First, the browser window will not be fullscreened. This
-// allows the user to retain control of their desktop to work in other browser
-// tabs or applications while the fullscreen view is displayed on a remote
-// screen. Second, FullscreenController will auto-resize fullscreen widgets to
-// that of the capture video resolution when they are hidden (e.g., when a user
-// has switched to another tab). This is both a performance and quality
-// improvement since scaling and letterboxing steps can be skipped in the
-// capture pipeline.
+// All fullscreen widgets are displayed within the tab contents area, and
+// FullscreenController will expand the browser window so that the tab contents
+// area fills the entire screen. However, special behavior applies when a tab is
+// being screen-captured. First, the browser window will not be
+// fullscreened. This allows the user to retain control of their desktop to work
+// in other browser tabs or applications while the fullscreen view is displayed
+// on a remote screen. Second, FullscreenController will auto-resize fullscreen
+// widgets to that of the capture video resolution when they are hidden (e.g.,
+// when a user has switched to another tab). This is both a performance and
+// quality improvement since scaling and letterboxing steps can be skipped in
+// the capture pipeline.
// This class implements fullscreen and mouselock behaviour.
class FullscreenController : public content::NotificationObserver {
@@ -201,9 +200,6 @@ class FullscreenController : public content::NotificationObserver {
bool IsPrivilegedFullscreenForTab() const;
void SetPrivilegedFullscreenForTesting(bool is_privileged);
- // Returns true if fullscreen-within-tab has been enabled for the
- // |browser_|. See 'FullscreenWithinTab Note'.
- bool IsFullscreenWithinTabPossible() const;
// Returns true if |web_contents| was toggled into/out of fullscreen mode as a
// screen-captured tab. See 'FullscreenWithinTab Note'.
bool MaybeToggleFullscreenForCapturedTab(content::WebContents* web_contents,
« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm ('k') | chrome/browser/ui/fullscreen/fullscreen_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698