Source/bindings/scripts/v8_types.py - Issue 386353002: Implement reflected attributes of HTMLMarqueeElement in Blink-in-JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 386353002: Implement reflected attributes of HTMLMarqueeElement in Blink-in-JS (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index 46b005222f31cbda0999e237c8251aaa55bd2d2f..d92b2629fecd14bb9eabe4ee27991f18f05852b7 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -539,7 +539,7 @@ def preprocess_idl_type_and_value(idl_type, cpp_value, extended_attributes):

idl_type.base_type in ['unsigned long', 'unsigned short']):

cpp_value = cpp_value.replace('getUnsignedIntegralAttribute',

'getIntegralAttribute')

- cpp_value = 'std::max(0, %s)' % cpp_value

+ cpp_value = 'std::max(0, int(%s))' % cpp_value

abarth-chromium 2014/07/14 06:04:35 static_cast<int>(...)

haraken 2014/07/14 09:59:12 Done.

return idl_type, cpp_value