Issue 386343004: WebAudio: Use references instead of pointers in AudioNodeInput and AudioNodeOutput.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 386343004: WebAudio: Use references instead of pointers in AudioNodeInput and AudioNodeOutput. (Closed)

Created:
6 years, 5 months ago by tkent

Modified:
6 years, 5 months ago

Reviewers:
keishi

CC:
blink-reviews, Raymond Toy

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

WebAudio: Use references instead of pointers in AudioNodeInput and AudioNodeOutput. We can remove some unnecessary assertions and null checks. BUG=392788 TEST=none; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178033

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -101 lines)			Patch
M	Source/modules/webaudio/AudioNode.cpp	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/modules/webaudio/AudioNodeInput.h	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/modules/webaudio/AudioNodeInput.cpp	View	8 chunks	+32 lines, -50 lines	0 comments	Download
M	Source/modules/webaudio/AudioNodeOutput.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/modules/webaudio/AudioNodeOutput.cpp	View	4 chunks	+13 lines, -33 lines	0 comments	Download
M	Source/modules/webaudio/AudioParam.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/386343004/1

6 years, 5 months ago (2014-07-14 08:00:23 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...

6 years, 5 months ago (2014-07-14 08:29:48 UTC) #5

Message was sent while issue was closed.

Change committed as 178033