Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: Source/modules/webaudio/AudioNodeOutput.h

Issue 386343004: WebAudio: Use references instead of pointers in AudioNodeInput and AudioNodeOutput. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/webaudio/AudioNodeInput.cpp ('k') | Source/modules/webaudio/AudioNodeOutput.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 private: 85 private:
86 AudioNodeOutput(AudioNode*, unsigned numberOfChannels); 86 AudioNodeOutput(AudioNode*, unsigned numberOfChannels);
87 87
88 AudioNode* m_node; 88 AudioNode* m_node;
89 89
90 friend class AudioNodeInput; 90 friend class AudioNodeInput;
91 friend class AudioParam; 91 friend class AudioParam;
92 92
93 // These are called from AudioNodeInput. 93 // These are called from AudioNodeInput.
94 // They must be called with the context's graph lock. 94 // They must be called with the context's graph lock.
95 void addInput(AudioNodeInput*); 95 void addInput(AudioNodeInput&);
96 void removeInput(AudioNodeInput*); 96 void removeInput(AudioNodeInput&);
97 void addParam(AudioParam*); 97 void addParam(AudioParam&);
98 void removeParam(AudioParam*); 98 void removeParam(AudioParam&);
99 99
100 // fanOutCount() is the number of AudioNodeInputs that we're connected to. 100 // fanOutCount() is the number of AudioNodeInputs that we're connected to.
101 // This method should not be called in audio thread rendering code, instead renderingFanOutCount() should be used. 101 // This method should not be called in audio thread rendering code, instead renderingFanOutCount() should be used.
102 // It must be called with the context's graph lock. 102 // It must be called with the context's graph lock.
103 unsigned fanOutCount(); 103 unsigned fanOutCount();
104 104
105 // Similar to fanOutCount(), paramFanOutCount() is the number of AudioParams that we're connected to. 105 // Similar to fanOutCount(), paramFanOutCount() is the number of AudioParams that we're connected to.
106 // This method should not be called in audio thread rendering code, instead renderingParamFanOutCount() should be used. 106 // This method should not be called in audio thread rendering code, instead renderingParamFanOutCount() should be used.
107 // It must be called with the context's graph lock. 107 // It must be called with the context's graph lock.
108 unsigned paramFanOutCount(); 108 unsigned paramFanOutCount();
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 // These value should only be changed at the very start or end of the render ing quantum. 145 // These value should only be changed at the very start or end of the render ing quantum.
146 unsigned m_renderingFanOutCount; 146 unsigned m_renderingFanOutCount;
147 unsigned m_renderingParamFanOutCount; 147 unsigned m_renderingParamFanOutCount;
148 148
149 WillBePersistentHeapHashSet<RefPtrWillBeMember<AudioParam> > m_params; 149 WillBePersistentHeapHashSet<RefPtrWillBeMember<AudioParam> > m_params;
150 }; 150 };
151 151
152 } // namespace WebCore 152 } // namespace WebCore
153 153
154 #endif // AudioNodeOutput_h 154 #endif // AudioNodeOutput_h
OLDNEW
« no previous file with comments | « Source/modules/webaudio/AudioNodeInput.cpp ('k') | Source/modules/webaudio/AudioNodeOutput.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698