Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 385843002: Update page_cycler to use results.AddValue(...). (Closed)

Created:
6 years, 5 months ago by nednguyen
Modified:
6 years, 5 months ago
Reviewers:
eakuefner, nduca, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update page_cycler to use results.AddValue(...). BUG=391943 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282571

Patch Set 1 #

Total comments: 2

Patch Set 2 : Get rid of int(float()) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M tools/perf/measurements/page_cycler.py View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
nednguyen
6 years, 5 months ago (2014-07-10 23:06:14 UTC) #1
eakuefner
lgtm
6 years, 5 months ago (2014-07-11 01:33:44 UTC) #2
eakuefner
lgtm
6 years, 5 months ago (2014-07-11 01:33:46 UTC) #3
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-07-11 01:49:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/385843002/1
6 years, 5 months ago (2014-07-11 01:52:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-11 01:52:20 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-11 01:52:20 UTC) #7
tonyg
lgtm https://codereview.chromium.org/385843002/diff/1/tools/perf/measurements/page_cycler.py File tools/perf/measurements/page_cycler.py (right): https://codereview.chromium.org/385843002/diff/1/tools/perf/measurements/page_cycler.py#newcode135 tools/perf/measurements/page_cycler.py:135: 'ms', int(float(tab.EvaluateJavaScript('__pc_load_time'))))) Not sure, but can we get ...
6 years, 5 months ago (2014-07-11 02:12:16 UTC) #8
nednguyen
https://codereview.chromium.org/385843002/diff/1/tools/perf/measurements/page_cycler.py File tools/perf/measurements/page_cycler.py (right): https://codereview.chromium.org/385843002/diff/1/tools/perf/measurements/page_cycler.py#newcode135 tools/perf/measurements/page_cycler.py:135: 'ms', int(float(tab.EvaluateJavaScript('__pc_load_time'))))) On 2014/07/11 02:12:16, tonyg wrote: > Not ...
6 years, 5 months ago (2014-07-11 03:10:39 UTC) #9
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-07-11 03:10:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/385843002/20001
6 years, 5 months ago (2014-07-11 03:12:21 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 07:12:09 UTC) #12
Message was sent while issue was closed. 
Change committed as 282571

Powered by Google App Engine
This is Rietveld 408576698