Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 385843002: Update page_cycler to use results.AddValue(...). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Get rid of int(float()) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/page_cycler.py
diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py
index babf272f39b8b21f85ab13c5ac4ab891f07d4759..20e751a2728623831fdd972531d28d78d45eda8a 100644
--- a/tools/perf/measurements/page_cycler.py
+++ b/tools/perf/measurements/page_cycler.py
@@ -26,6 +26,8 @@ from metrics import speedindex
from metrics import v8_object_stats
from telemetry.core import util
from telemetry.page import page_measurement
+from telemetry.value import scalar
+
class PageCycler(page_measurement.PageMeasurement):
options = {'pageset_repeat': 10}
@@ -128,9 +130,9 @@ class PageCycler(page_measurement.PageMeasurement):
chart_name_prefix = ('cold_' if self.IsRunCold(page.url) else
'warm_')
- results.Add('page_load_time', 'ms',
- int(float(tab.EvaluateJavaScript('__pc_load_time'))),
- chart_name=chart_name_prefix+'times')
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, '%stimes.page_load_time' % chart_name_prefix,
+ 'ms', tab.EvaluateJavaScript('__pc_load_time')))
self._has_loaded_page[page.url] += 1
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698