roll "common" DEPS, and replace tools/pyutils with it

roll "common" DEPS, and replace tools/pyutils with it

BUG=skia:2682
Committed: https://skia.googlesource.com/skia/+/133931f4abdafa5bb0bdea3a02af1e5a70d5ac98

[epoger, 2014-07-10 21:56:20]

Robbie- Please see the one comment I directed at you below.  Any ideas?

Eric- Please review overall.

https://codereview.chromium.org/385783002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/385783002/diff/20001/DEPS#newcode24
DEPS:24: # TODO(epoger): I don't know why the label I use here has to have the
"skia/"
Robbie: Any idea why this is the case?  (I see that you reviewed the addition of
"recursedeps" in https://codereview.chromium.org/363103002 , so I figured you
might know.)

[iannucci, 2014-07-10 22:01:42]

https://codereview.chromium.org/385783002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/385783002/diff/20001/DEPS#newcode24
DEPS:24: # TODO(epoger): I don't know why the label I use here has to have the
"skia/"
On 2014/07/10 21:56:20, epoger wrote:
> Robbie: Any idea why this is the case?  (I see that you reviewed the addition
of
> "recursedeps" in https://codereview.chromium.org/363103002 , so I figured you
> might know.)

I suspect that `use_relative_paths` is not respected by the implementation of
recursedeps. This sounds like a bug in gclient: crbug.com/393000

[borenet, 2014-07-11 12:59:11]

LGTM but not a fan of:
# pylint: disable=123
offending_line
# pylint: enable=123

https://codereview.chromium.org/385783002/diff/20001/gm/rebaseline_server/com...
File gm/rebaseline_server/compare_configs.py (right):

https://codereview.chromium.org/385783002/diff/20001/gm/rebaseline_server/com...
gm/rebaseline_server/compare_configs.py:20: # pylint: enable=W0611
Why not:

import fix_pythonpath  # pylint: disable=W0611

https://codereview.chromium.org/385783002/diff/20001/gm/rebaseline_server/com...
File gm/rebaseline_server/compare_rendered_pictures.py (right):

https://codereview.chromium.org/385783002/diff/20001/gm/rebaseline_server/com...
gm/rebaseline_server/compare_rendered_pictures.py:20: # pylint: enable=W0611
Same comment.

https://codereview.chromium.org/385783002/diff/20001/gm/rebaseline_server/com...
File gm/rebaseline_server/compare_to_expectations.py (right):

https://codereview.chromium.org/385783002/diff/20001/gm/rebaseline_server/com...
gm/rebaseline_server/compare_to_expectations.py:22: # pylint: enable=W0611
Same comment.

https://codereview.chromium.org/385783002/diff/20001/gm/rebaseline_server/dow...
File gm/rebaseline_server/download_actuals.py (right):

https://codereview.chromium.org/385783002/diff/20001/gm/rebaseline_server/dow...
gm/rebaseline_server/download_actuals.py:22: # pylint: enable=W0611
Same comment.

https://codereview.chromium.org/385783002/diff/20001/gm/rebaseline_server/dow...
File gm/rebaseline_server/download_actuals_test.py (right):

https://codereview.chromium.org/385783002/diff/20001/gm/rebaseline_server/dow...
gm/rebaseline_server/download_actuals_test.py:27: # pylint: enable=W0611
Same comment.

[epoger, 2014-07-11 14:18:42]

Improved how I disable the pylint warnings (thanks!) in patchset 3.

And I set COMMIT=false until I figure out what to do about
http://crbug.com/393000 ('Gclient recursedeps feature doesn't seem to respect
use_relative_paths') .  I'm gonna look into that now.

https://codereview.chromium.org/385783002/diff/20001/gm/rebaseline_server/com...
File gm/rebaseline_server/compare_configs.py (right):

https://codereview.chromium.org/385783002/diff/20001/gm/rebaseline_server/com...
gm/rebaseline_server/compare_configs.py:20: # pylint: enable=W0611
On 2014/07/11 12:59:11, borenet wrote:
> Why not:
> 
> import fix_pythonpath  # pylint: disable=W0611

Good idea, fixed throughout.  I wasn't sure that would re-enable the warning for
following lines, but I confirmed that it does.

[epoger, 2014-07-11 15:22:02]

Eric- WDYT of the DEPS workaround in patchset 4?

I would like to commit it with that change, so that we are not blocked by
http://crbug.com/393000 ('Gclient recursedeps feature doesn't seem to respect
use_relative_paths')

[borenet, 2014-07-11 15:25:23]

On 2014/07/11 15:22:02, epoger wrote:
> Eric- WDYT of the DEPS workaround in patchset 4?
> 
> I would like to commit it with that change, so that we are not blocked by
> http://crbug.com/393000 ('Gclient recursedeps feature doesn't seem to respect
> use_relative_paths')

So we're back to the old way?  Unfortunate, but if that's what we have to do,
LGTM.

[epoger, 2014-07-11 15:29:48]

On 2014/07/11 15:25:23, borenet wrote:
> On 2014/07/11 15:22:02, epoger wrote:
> > Eric- WDYT of the DEPS workaround in patchset 4?
> > 
> > I would like to commit it with that change, so that we are not blocked by
> > http://crbug.com/393000 ('Gclient recursedeps feature doesn't seem to
respect
> > use_relative_paths')
> 
> So we're back to the old way?  

Sort of.  skia/DEPS still has to import google-api-python-client and its
dependencies directly.  But now it's compartmentalizing those dependencies
better, by importing them into skia/common/third_party instead of
skia/third_party.

And as of patchset 5, I think it's clearer what stuff needs to stay in sync.

[borenet, 2014-07-11 15:31:43]

LGTM at patch set 5.  New grouping is better.

[epoger, 2014-07-11 15:32:36]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-07-11 15:33:28]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/epoger@google.com/385783002/100001

[commit-bot: I haz the power, 2014-07-11 15:52:38]

Change committed as 133931f4abdafa5bb0bdea3a02af1e5a70d5ac98