Update recurselist to be a set, call it recursedeps now.

Update recurselist to be a set, call it recursedeps now.

Now that recurselist is no longer a list, it doesn't make
sense to call it recurselist.  recurseset is available, but
that's not as easy to read/say compared to recurselist.
Call this recursedeps, instead.

R=iannucci@chromium.org
BUG=390246
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=281107

[cmp, 2014-07-02 22:01:54]

+agable

[cmp, 2014-07-02 22:02:08]

+dpranke

[agable, 2014-07-02 22:05:06]

LGTM % set vs. tuple.

https://codereview.chromium.org/363103002/diff/20001/tests/gclient_test.py
File tests/gclient_test.py (right):

https://codereview.chromium.org/363103002/diff/20001/tests/gclient_test.py#ne...
tests/gclient_test.py:667: - |recursedeps| = (...) on 2 levels means we pull
exactly 3 deps
Should be {...} for a set? Tuples can be converted to sets, so this works, but
below you explicitly call it a set so this is sending mixed messages.

[cmp, 2014-07-02 22:16:41]

https://codereview.chromium.org/363103002/diff/20001/tests/gclient_test.py
File tests/gclient_test.py (right):

https://codereview.chromium.org/363103002/diff/20001/tests/gclient_test.py#ne...
tests/gclient_test.py:667: - |recursedeps| = (...) on 2 levels means we pull
exactly 3 deps
On 2014/07/02 22:05:06, agable wrote:
> Should be {...} for a set? Tuples can be converted to sets, so this works, but
> below you explicitly call it a set so this is sending mixed messages.

Done.

[cmp, 2014-07-02 23:16:39]

The CQ bit was checked by cmp@chromium.org

[commit-bot: I haz the power, 2014-07-02 23:17:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmp@chromium.org/363103002/40001

[commit-bot: I haz the power, 2014-07-02 23:20:10]

Change committed as 281107

[iannucci, 2014-07-03 18:55:59]

lgtm

https://codereview.chromium.org/363103002/diff/40001/gclient.py
File gclient.py (right):

https://codereview.chromium.org/363103002/diff/40001/gclient.py#newcode596
gclient.py:596: self.recursedeps = local_scope.get('recursedeps', None)
could also cast to a set here. If it's already a set then it shouldn't do
anything. If not, then everything else won't be assuming set and actually
dealing with e.g. list, tuple, dict, etc.

https://codereview.chromium.org/363103002/diff/40001/tests/gclient_test.py
File tests/gclient_test.py (right):

https://codereview.chromium.org/363103002/diff/40001/tests/gclient_test.py#ne...
tests/gclient_test.py:686: 'recursedeps = {"bar"}')
Note that the {'foo'} syntax is actually python 2.7, and as M-A recently pointed
out, not all masters are actually on 2.7 yet. This just means we'll have to use
set(('foo',)) in the DEPS files for now.

[Jason Robbins -- corp, 2014-09-11 20:28:30]

jrobbins@google.com changed reviewers:
+ dpranke@chromium.org
- dpranke@chromioum.org