Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 385693002: Split linux library expectations for debian into 32 and 64 bit, remove libgcc1 from 64 after clang … (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, grt+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Split linux library expectations for debian into 32 and 64 bit, remove libgcc1 from 64 after clang switch BUG=360311 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282379

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -33 lines) Patch
M chrome/installer/linux/debian/build.sh View 1 chunk +3 lines, -2 lines 2 comments Download
D chrome/installer/linux/debian/expected_deps View 1 chunk +0 lines, -31 lines 0 comments Download
A + chrome/installer/linux/debian/expected_deps_ia32 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/installer/linux/debian/expected_deps_x64 View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
6 years, 5 months ago (2014-07-10 18:06:11 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/385693002/diff/1/chrome/installer/linux/debian/build.sh File chrome/installer/linux/debian/build.sh (right): https://codereview.chromium.org/385693002/diff/1/chrome/installer/linux/debian/build.sh#newcode283 chrome/installer/linux/debian/build.sh:283: echo "chrome/installer/linux/debian/expected_deps_ia32" maybe just expected_deps_$TARGETARCH here?
6 years, 5 months ago (2014-07-10 18:07:42 UTC) #2
Nico
https://codereview.chromium.org/385693002/diff/1/chrome/installer/linux/debian/build.sh File chrome/installer/linux/debian/build.sh (right): https://codereview.chromium.org/385693002/diff/1/chrome/installer/linux/debian/build.sh#newcode283 chrome/installer/linux/debian/build.sh:283: echo "chrome/installer/linux/debian/expected_deps_ia32" On 2014/07/10 18:07:42, Lei Zhang wrote: > ...
6 years, 5 months ago (2014-07-10 18:08:29 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-10 18:10:17 UTC) #4
Lei Zhang
On 2014/07/10 18:08:29, Nico (away) wrote: > https://codereview.chromium.org/385693002/diff/1/chrome/installer/linux/debian/build.sh > File chrome/installer/linux/debian/build.sh (right): > > https://codereview.chromium.org/385693002/diff/1/chrome/installer/linux/debian/build.sh#newcode283 ...
6 years, 5 months ago (2014-07-10 18:10:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/385693002/1
6 years, 5 months ago (2014-07-10 18:10:50 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 18:12:33 UTC) #7
Message was sent while issue was closed. 
Change committed as 282379

Powered by Google App Engine
This is Rietveld 408576698