Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: chrome/installer/linux/debian/build.sh

Issue 385693002: Split linux library expectations for debian into 32 and 64 bit, remove libgcc1 from 64 after clang … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/installer/linux/debian/expected_deps » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/bin/bash 1 #!/bin/bash
2 # 2 #
3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 # TODO(mmoss) This currently only works with official builds, since non-official 7 # TODO(mmoss) This currently only works with official builds, since non-official
8 # builds don't add the "${BUILDDIR}/installer/" files needed for packaging. 8 # builds don't add the "${BUILDDIR}/installer/" files needed for packaging.
9 9
10 set -e 10 set -e
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 LD_LIBRARY_PATH=$SAVE_LDLP 268 LD_LIBRARY_PATH=$SAVE_LDLP
269 fi 269 fi
270 270
271 # Format it nicely and save it for comparison. 271 # Format it nicely and save it for comparison.
272 # The grep -v is for a duplicate libc6 dep caused by Lucid glibc silliness. 272 # The grep -v is for a duplicate libc6 dep caused by Lucid glibc silliness.
273 echo "$DPKG_SHLIB_DEPS" | sed 's/, /\n/g' | \ 273 echo "$DPKG_SHLIB_DEPS" | sed 's/, /\n/g' | \
274 grep -v '^libc6 (>= 2.3.6-6~)$' > actual 274 grep -v '^libc6 (>= 2.3.6-6~)$' > actual
275 275
276 # Compare the expected dependency list to the generate list. 276 # Compare the expected dependency list to the generate list.
277 BAD_DIFF=0 277 BAD_DIFF=0
278 diff "$SCRIPTDIR/expected_deps" actual || BAD_DIFF=1 278 diff "$SCRIPTDIR/expected_deps_$TARGETARCH" actual || BAD_DIFF=1
279 if [ $BAD_DIFF -ne 0 ] && [ -z "${IGNORE_DEPS_CHANGES:-}" ]; then 279 if [ $BAD_DIFF -ne 0 ] && [ -z "${IGNORE_DEPS_CHANGES:-}" ]; then
280 echo 280 echo
281 echo "ERROR: Shared library dependencies changed!" 281 echo "ERROR: Shared library dependencies changed!"
282 echo "If this is intentional, please update:" 282 echo "If this is intentional, please update:"
283 echo "chrome/installer/linux/debian/expected_deps" 283 echo "chrome/installer/linux/debian/expected_deps_ia32"
Lei Zhang 2014/07/10 18:07:42 maybe just expected_deps_$TARGETARCH here?
Nico 2014/07/10 18:08:29 Dunno, this is what the rpm script does. Seems lik
284 echo "chrome/installer/linux/debian/expected_deps_x64"
284 echo 285 echo
285 exit $BAD_DIFF 286 exit $BAD_DIFF
286 fi 287 fi
287 rm -rf "$DUMMY_STAGING_DIR" 288 rm -rf "$DUMMY_STAGING_DIR"
288 289
289 # Additional dependencies not in the dpkg-shlibdeps output. 290 # Additional dependencies not in the dpkg-shlibdeps output.
290 # Pull a more recent version of NSS than required by runtime linking, for 291 # Pull a more recent version of NSS than required by runtime linking, for
291 # security and stability updates in NSS. 292 # security and stability updates in NSS.
292 ADDITION_DEPS="ca-certificates, libappindicator1, libcurl3, \ 293 ADDITION_DEPS="ca-certificates, libappindicator1, libcurl3, \
293 libnss3 (>= 3.14.3), lsb-base (>=3.2), xdg-utils (>= 1.0.2), wget" 294 libnss3 (>= 3.14.3), lsb-base (>=3.2), xdg-utils (>= 1.0.2), wget"
(...skipping 28 matching lines...) Expand all
322 ;; 323 ;;
323 * ) 324 * )
324 echo 325 echo
325 echo "ERROR: Don't know how to build DEBs for '$TARGETARCH'." 326 echo "ERROR: Don't know how to build DEBs for '$TARGETARCH'."
326 echo 327 echo
327 exit 1 328 exit 1
328 ;; 329 ;;
329 esac 330 esac
330 331
331 do_package 332 do_package
OLDNEW
« no previous file with comments | « no previous file | chrome/installer/linux/debian/expected_deps » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698