Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 385663002: Revert of WebGL: Free temporary GPU resources held by inactive or hidden WebGL. (Closed)

Created:
6 years, 5 months ago by Justin Novosad
Modified:
6 years, 5 months ago
CC:
aandrey+blink_chromium.org, adamk+blink_chromium.org, blink-reviews, Rik, danakj, dglazkov+blink, krit, dsinclair, jamesr, jbroman, pdr., rwlbuis, Stephen Chennney, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of WebGL: Free temporary GPU resources held by inactive or hidden WebGL. (https://codereview.chromium.org/251023004/) Reason for revert: The following tests have become flaky after this change was committed: ContextLost.WebGLContextLostFromGPUProcessExit WebglConformance.conformance_context_incorrect_context_object_behaviour The flakiness was observed in debug builds on Win7 and Linux http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&testType=webgl_conformance_tests&tests=WebglConformance.conformance_context_incorrect_context_object_behaviour http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&testType=context_lost_tests&tests=ContextLost.WebGLContextLostFromGPUProcessExit Original issue's description: > WebGL: Free temporary GPU resources held by inactive or hidden WebGL. > > This CL applies Canvas 2D change in r165966 to WebGL > > TEST=fast/canvas/webgl/webgl-composite-modes-tabswitching.html, > DrawingBufferTest.verifySetIsHiddenProperlyAffectsMailboxes > > BUG=391400 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -236 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/canvas/webgl/webgl-composite-modes-tabswitching.html View 1 chunk +0 lines, -153 lines 0 comments Download
D LayoutTests/fast/canvas/webgl/webgl-composite-modes-tabswitching-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +10 lines, -8 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.h View 3 chunks +4 lines, -7 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.h View 4 chunks +1 line, -4 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 5 chunks +3 lines, -25 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBufferTest.cpp View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Justin Novosad
Created Revert of WebGL: Free temporary GPU resources held by inactive or hidden WebGL.
6 years, 5 months ago (2014-07-10 17:10:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/385663002/1
6 years, 5 months ago (2014-07-10 17:11:04 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 17:11:04 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-10 17:11:10 UTC) #4
Justin Novosad
6 years, 5 months ago (2014-07-10 17:15:49 UTC) #5
On 2014/07/10 17:11:10, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

Cancelling. kbr beat me to it: https://codereview.chromium.org/381113003

Powered by Google App Engine
This is Rietveld 408576698