Source/core/html/HTMLCanvasElement.cpp - Issue 385663002: Revert of WebGL: Free temporary GPU resources held by inactive or hidden WebGL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLCanvasElement.cpp

Issue 385663002: Revert of WebGL: Free temporary GPU resources held by inactive or hidden WebGL. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/webgl/webgl-composite-modes-tabswitching-expected.txt ('k') | Source/core/html/canvas/CanvasRenderingContext.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLCanvasElement.cpp

diff --git a/Source/core/html/HTMLCanvasElement.cpp b/Source/core/html/HTMLCanvasElement.cpp

index 80bfc3112a75235d2a1458a52fd19114b2c75bc9..bff1d0678e104fb06abbebdc0c4de0344297ea9e 100644

--- a/Source/core/html/HTMLCanvasElement.cpp

+++ b/Source/core/html/HTMLCanvasElement.cpp

@@ -650,14 +650,16 @@

void HTMLCanvasElement::didChangeVisibilityState(PageVisibilityState visibility)

{

- if (!m_context)

- return;

- bool hidden = visibility != PageVisibilityStateVisible;

- m_context->setIsHidden(hidden);

- if (hidden) {

- clearCopiedImage();

- if (is3D()) {

- discardImageBuffer();

+ if (hasImageBuffer()) {

+ bool hidden = visibility != PageVisibilityStateVisible;

+ if (hidden) {

+ clearCopiedImage();

+ if (is3D()) {

+ discardImageBuffer();

+ }

+ if (hasImageBuffer()) {

+ m_imageBuffer->setIsHidden(hidden);

}