Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 385613002: Parser sync tests for `let` identifiers (Closed)

Created:
6 years, 5 months ago by rossberg
Modified:
6 years, 5 months ago
Reviewers:
marja
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Parser sync tests for `let` identifiers R=marja@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22324

Patch Set 1 #

Total comments: 3

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -11 lines) Patch
M src/parser.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 3 chunks +45 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
6 years, 5 months ago (2014-07-10 14:28:45 UTC) #1
marja
lgtm https://codereview.chromium.org/385613002/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/385613002/diff/1/test/cctest/test-parsing.cc#newcode1782 test/cctest/test-parsing.cc:1782: static const ParserFlag always_flags[] = {kAllowArrowFunctions}; Afaics this ...
6 years, 5 months ago (2014-07-10 14:35:13 UTC) #2
rossberg
https://codereview.chromium.org/385613002/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/385613002/diff/1/test/cctest/test-parsing.cc#newcode1782 test/cctest/test-parsing.cc:1782: static const ParserFlag always_flags[] = {kAllowArrowFunctions}; On 2014/07/10 14:35:13, ...
6 years, 5 months ago (2014-07-10 14:39:00 UTC) #3
rossberg
6 years, 5 months ago (2014-07-10 14:39:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22324 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698