Parser sync tests for `let` identifiers

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1731 matching lines @@
     "++super;",
     "super++;",
     "function foo super",
     NULL
   };
 
   RunParserSyncTest(context_data, statement_data, kError);
 }
 
 
+TEST(NoErrorsLetSloppyAllModes) {
+  // In sloppy mode, it's okay to use "let" as identifier.
+  const char* context_data[][2] = {
+    { "", "" },
+    { "function f() {", "}" },
+    { "(function f() {", "})" },
+    { NULL, NULL }
+  };
+
+  const char* statement_data[] = {
+    "var let;",
+    "var foo, let;",
+    "try { } catch (let) { }",
+    "function let() { }",
+    "(function let() { })",
+    "function foo(let) { }",
+    "function foo(bar, let) { }",
+    "let = 1;",
+    "var foo = let = 1;",
+    "let * 2;",
+    "++let;",
+    "let++;",
+    "let: 34",
+    "function let(let) { let: let(let + let(0)); }",
+    "({ let: 1 })",
+    "({ get let() { 1 } })",
+    "let(100)",
+    NULL
+  };
+
+  static const ParserFlag always_flags[] = {kAllowArrowFunctions};

[marja, 2014/07/10 14:35:13]

Afaics this test doesn't need kAllowArrowFunctions, and the test where you
copied it doesn't need it either (it's there by mistake :/).

RunParserSyncTest(context_data, statement_data, kSuccess); should be enough.
That will run the test both with and without arrow functions.

[rossberg, 2014/07/10 14:39:00]

Right, done.

+  RunParserSyncTest(context_data, statement_data, kSuccess, NULL, 0,
+                    always_flags, ARRAY_SIZE(always_flags));
+}
+
+
 TEST(NoErrorsYieldSloppyAllModes) {
   // In sloppy mode, it's okay to use "yield" as identifier, *except* inside a
-  // generator (see next test).
+  // generator (see other test).
   const char* context_data[][2] = {
     { "", "" },
     { "function not_gen() {", "}" },
     { "(function not_gen() {", "})" },
     { NULL, NULL }
   };
 
   const char* statement_data[] = {
     "var yield;",
     "var foo, yield;",
     "try { } catch (yield) { }",
     "function yield() { }",
     "(function yield() { })",
     "function foo(yield) { }",
     "function foo(bar, yield) { }",
     "yield = 1;",
     "var foo = yield = 1;",
+    "yield * 2;",
     "++yield;",
     "yield++;",
     "yield: 34",
-    "function yield(yield) { yield: yield (yield + yield (0)); }",
+    "function yield(yield) { yield: yield (yield + yield(0)); }",
     "({ yield: 1 })",
     "({ get yield() { 1 } })",
-    "yield (100)",
+    "yield(100)",
+    "yield[100]",
     NULL
   };
 
   static const ParserFlag always_flags[] = {kAllowArrowFunctions};

[marja, 2014/07/10 14:35:13]

Namely here... we don't need kAllowArrowFunctions.

   RunParserSyncTest(context_data, statement_data, kSuccess, NULL, 0,
                     always_flags, ARRAY_SIZE(always_flags));
 }
 
 
 TEST(NoErrorsYieldSloppyGeneratorsEnabled) {
   // In sloppy mode, it's okay to use "yield" as identifier, *except* inside a
   // generator (see next test).
   const char* context_data[][2] = {
     { "", "" },
     { "function not_gen() {", "}" },
     { "function * gen() { function not_gen() {", "} }" },
     { "(function not_gen() {", "})" },
     { "(function * gen() { (function not_gen() {", "}) })" },
     { NULL, NULL }
   };
 
   const char* statement_data[] = {
     "var yield;",
     "var foo, yield;",
     "try { } catch (yield) { }",
     "function yield() { }",
     "(function yield() { })",
     "function foo(yield) { }",
     "function foo(bar, yield) { }",
     "function * yield() { }",
     "(function * yield() { })",
     "yield = 1;",
     "var foo = yield = 1;",
+    "yield * 2;",
     "++yield;",
     "yield++;",
     "yield: 34",
-    "function yield(yield) { yield: yield (yield + yield (0)); }",
+    "function yield(yield) { yield: yield (yield + yield(0)); }",
     "({ yield: 1 })",
     "({ get yield() { 1 } })",
-    "yield (100)",
+    "yield(100)",
+    "yield[100]",
     NULL
   };
 
   // This test requires kAllowGenerators to succeed.
   static const ParserFlag always_true_flags[] = {
     kAllowGenerators
   };
   RunParserSyncTest(context_data, statement_data, kSuccess, NULL, 0,
                     always_true_flags, 1);
 }
@@ skipping 1272 matching lines @@
 
     // Arrow has more precedence, this is the same as: foo ? bar : (baz = {})
     "foo ? bar : baz => {}",
     NULL
   };
 
   static const ParserFlag always_flags[] = {kAllowArrowFunctions};
   RunParserSyncTest(context_data, statement_data, kSuccess, NULL, 0,
                     always_flags, ARRAY_SIZE(always_flags));
 }